ENH: Remove unused default process count parameter #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHrlS98
reviewed
Dec 13, 2021
jhlegarreta
force-pushed
the
RemoveProcessCountValidationMethodUnusedDefault
branch
from
943f03b to
e35494a
Compare
CHrlS98
reviewed
Dec 13, 2021
jhlegarreta
force-pushed
the
RemoveProcessCountValidationMethodUnusedDefault
branch
from
e35494a to
8fa6548
Compare
CHrlS98
reviewed
Dec 15, 2021
Remove unused default process count parameter from the process count validation method. Take advantage of the commit to: - Change the "less than or equal to" 0 condition on the value to be returned to a "strictly less than": if a value of 0 is provided in the arguments, then the returned value corresponds to the available core count, and thus the value will never be less than 1. - Improve the method documentation: state clearly the range of valid values and document the method behavior if the process count is not contained in the arguments. - Fix the returned value docstring. - Fix the logged process count in script.
jhlegarreta
force-pushed
the
RemoveProcessCountValidationMethodUnusedDefault
branch
from
8fa6548 to
e733d7d
Compare
CHrlS98
approved these changes
Dec 15, 2021
arnaudbore
approved these changes
Dec 20, 2021
jhlegarreta
deleted the
RemoveProcessCountValidationMethodUnusedDefault
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused default process count parameter from the process count
validation method.
Take advantage of the commit to:
the arguments.