-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add module decompose connectivity #86
base: main
Are you sure you want to change the base?
[WIP] add module decompose connectivity #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🍻 I added some minor comments. What was the reasoning behind the naming of the module? I understand that it is used for connectivity, but I tend to prefer TRACTOGRAM_DECOMPOSE
since we apply it on a tractogram.
And for the concatenation of the tractogram, if you want, you can add it as an option in this module. It could then be toggle on/off by a task.ext
parameter, but feel free to choose which one you prefer.
…ompose-connectivity
…reStanislas/nf-neuro into add-module-decompose-connectivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes
new module for decompose connectivity, The module is a copy of the module in nf-pediatric created by @gagnonanthony. I didn't add the option to concatenate tractograms before decomposing because it's specific to disconets_flow. However, I'm not sure that a module dedicated to tractogram concatenation would be useful, and it could be an option in the remove invalid streamlines module.
List test packages used by your subworkflow
Checklist before requesting a review
./subworkflows/nf-neuro/<category>/<tool>/main.nf
./subworkflows/nf-neuro/<category>/<tool>/meta.yml
./subworkflows/nf-neuro/<category>/<tool>/tests/main.nf.test
main.nf.test.snap
snapshotsprettier
andeditorconfig-checker
to fix common syntax issuesnf-core subworkflows lint
and fix all errors