-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Python 3.7 support #355
Conversation
numba 0.57 requires Python 3.8
Ruff's config still has: target-version = "py37" |
Oops, fixed it, thank you! |
@jpivarski thoughts? Should this go in 1.1? I’m thinking it might be good to do now since 1.1 doesn’t support numba on 3.7, while 1.0 does. |
Yes, it could be good to do all of the dependency version threshold changes in 1.1, instead of using multiple minor versions or using up numbers. It's a tighter set of version constraints for someone who wants #347, but it doesn't sound like a likely scenario. ("I want I'd say go ahead and add it to Vector 1.1. |
It's not just about using up numbers, this release is actually a downgrade for Python 3.7 users - they now can't use numba with vector anymore if we don't bump the Python version now. Using |
Following #348 (comment), this PR removes the support of Python 3.7 from vector. I'm still not completely sure if there was a concensus regarding this but I'll be happy to close this PR if we do want to support Python 3.7.
Description
Kindly take a look at CONTRIBUTING.md.
Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.
Checklist
$ pre-commit run --all-files
or$ nox -s lint
)$ pytest
or$ nox -s tests
)$ cd docs; make clean; make html
or$ nox -s docs
)$ xdoctest ./src/vector
or$ nox -s doctests
)Before Merging