Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Python 3.7 support #355

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Conversation

Saransh-cpp
Copy link
Member

Following #348 (comment), this PR removes the support of Python 3.7 from vector. I'm still not completely sure if there was a concensus regarding this but I'll be happy to close this PR if we do want to support Python 3.7.

Description

Kindly take a look at CONTRIBUTING.md.

Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass the doctests? ($ xdoctest ./src/vector or $ nox -s doctests)

Before Merging

  • Summarize the commit messages into a brief review of the Pull request.

@henryiii
Copy link
Member

Ruff's config still has:

target-version = "py37"

@Saransh-cpp
Copy link
Member Author

Oops, fixed it, thank you!

@Saransh-cpp Saransh-cpp added this to the v1.1.0 milestone Jun 20, 2023
@henryiii
Copy link
Member

@jpivarski thoughts? Should this go in 1.1? I’m thinking it might be good to do now since 1.1 doesn’t support numba on 3.7, while 1.0 does.

@jpivarski
Copy link
Member

Yes, it could be good to do all of the dependency version threshold changes in 1.1, instead of using multiple minor versions or using up numbers.

It's a tighter set of version constraints for someone who wants #347, but it doesn't sound like a likely scenario. ("I want ak.sum to work on Vectors, but I'm using Python 3.7.")

I'd say go ahead and add it to Vector 1.1.

@henryiii
Copy link
Member

It's not just about using up numbers, this release is actually a downgrade for Python 3.7 users - they now can't use numba with vector anymore if we don't bump the Python version now. Using ak.sum is a new feature and won't break existing code like removing numba could.

@henryiii henryiii merged commit 9070e13 into scikit-hep:main Jun 22, 2023
@Saransh-cpp Saransh-cpp deleted the bump-python branch June 22, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants