-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace custom definition of np.isclose with numba's np.isclose #348
Conversation
@jpivarski, should we drop 3.7? If we wanted to support both for a bit, we could make the workaround conditional instead of immediately dropping it. But I’d only do that with a strong reason. |
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
8993c05
to
3865c8d
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 82.87% 83.01% +0.13%
==========================================
Files 96 96
Lines 11396 11372 -24
==========================================
- Hits 9445 9440 -5
+ Misses 1951 1932 -19
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Yes, please get rid of our custom isclose
and require the latest Numba.
Great, thanks for the quick reviews! |
Description
Closes #185
Checklist
$ pre-commit run --all-files
or$ nox -s lint
)$ pytest
or$ nox -s tests
)$ cd docs; make clean; make html
or$ nox -s docs
)$ xdoctest ./src/vector
or$ nox -s doctests
)Before Merging