Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace custom definition of np.isclose with numba's np.isclose #348

Merged
merged 5 commits into from
May 23, 2023

Conversation

Saransh-cpp
Copy link
Member

Description

Closes #185

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass the doctests? ($ xdoctest ./src/vector or $ nox -s doctests)

Before Merging

  • Summarize the commit messages into a brief review of the Pull request.

@Saransh-cpp Saransh-cpp added the cleanup Not broken, but could be more streamlined label May 22, 2023
@Saransh-cpp Saransh-cpp requested review from jpivarski and henryiii May 22, 2023 15:04
@henryiii
Copy link
Member

@jpivarski, should we drop 3.7?

If we wanted to support both for a bit, we could make the workaround conditional instead of immediately dropping it. But I’d only do that with a strong reason.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13 🎉

Comparison is base (78faba8) 82.87% compared to head (3865c8d) 83.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   82.87%   83.01%   +0.13%     
==========================================
  Files          96       96              
  Lines       11396    11372      -24     
==========================================
- Hits         9445     9440       -5     
+ Misses       1951     1932      -19     
Impacted Files Coverage Δ
src/vector/backends/_numba_object.py 69.83% <ø> (+0.64%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Yes, please get rid of our custom isclose and require the latest Numba.

@Saransh-cpp
Copy link
Member Author

Great, thanks for the quick reviews!

@Saransh-cpp Saransh-cpp merged commit 8559a2d into scikit-hep:main May 23, 2023
@Saransh-cpp Saransh-cpp deleted the numba-isclose branch May 23, 2023 19:03
@Saransh-cpp Saransh-cpp added this to the v1.1.0 milestone Jun 16, 2023
@Saransh-cpp Saransh-cpp mentioned this pull request Jun 19, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Not broken, but could be more streamlined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take Numba's np.isclose lowering instead of defining our own.
4 participants