Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drop Python 3.7 support #2044

Merged
merged 14 commits into from
Oct 12, 2022
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 10, 2022

Description

Following Discussion #2042, drop Python 3.7 support to follow NEP 29 development recommendations. As a result, drop the requirement of typing_extensions as that is needed for Python 3.7 only and update the lower bound on SciPy to v1.3.2 — the first release with Python 3.8 wheels.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Drop Python 3.7 support to follow NEP 29 development recommendations.
   - c.f. https://github.com/scikit-hep/pyhf/discussions/2042
* Drop typing_extensions as a requirement as that is needed by Python 3.7 only.
* Update lower bound of the supported scipy versions to v1.3.2, the first scipy release
  with Python 3.8 wheels.
* Update pre-commit hooks to use Python 3.8.

@matthewfeickert matthewfeickert added feat/enhancement New feature or request docs Documentation related tests pytest build Changes that affect the build system or external dependencies labels Oct 10, 2022
@matthewfeickert matthewfeickert self-assigned this Oct 10, 2022
src/pyhf/typing.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 98.30% // Head: 98.30% // No change to project coverage 👍

Coverage data is based on head (031c9c0) compared to base (3042b27).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2044   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4530     4530           
  Branches      645      645           
=======================================
  Hits         4453     4453           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 27.52% <ø> (ø)
doctest 61.14% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.7 ?
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/contrib/utils.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit 124a8d9 into main Oct 12, 2022
@matthewfeickert matthewfeickert deleted the build/drop-python-3.7-support branch October 12, 2022 04:53
matthewfeickert added a commit that referenced this pull request Oct 23, 2022
…2050)

* Add numpy metadata information to codemeta.json.
   - Amends PR #2041
* Update lower bound on scipy to v1.3.2 and remove typing-extensions.
   - Amends PR #2044
* Update codemetapy lower bound to v2.3.0 to ensure consistency of output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies docs Documentation related feat/enhancement New feature or request tests pytest
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants