build: Add numpy as a dependency explicitly #2041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add numpy explicitly as a dependency of pyhf. As the lower bound (and upper bound) of numpy is tightly controlled by scipy a lower bound is not given to avoid potential future confusion for pip's dependency resolver. Explicitly adding numpy as a dependency improves the metadata for packaging. e.g.
pip show
will now list numpy under the 'Requires' output.Note that no more information is contained with this addition, but it provides additional context to metadata inspection.
Before
This PR
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: