Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove requests install from JupyterLite REPL setup #2020

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

matthewfeickert
Copy link
Member

Description

Given the async nature of the Pyodide kernel #1775 (comment) requests isn't something we can usefully use for pyhf.contrib.utils.download in Pyodide examples. Given this, to simplify things as much as possible remove the install of requests from the setup of the JupyterLite REPL for the docs.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* To simplify things, remove the piplite install of requests from the JupyterLite REPL setup.
   - Given the async nature of Pyodide, requests isn't currently useful for examples using
     pyhf.contrib.utils.download. c.f. Issue #1775 for context.

@matthewfeickert matthewfeickert added the docs Documentation related label Sep 22, 2022
@matthewfeickert matthewfeickert self-assigned this Sep 22, 2022
@matthewfeickert
Copy link
Member Author

@matthewfeickert matthewfeickert changed the title docs: Remove requests install from in JupyterLite REPL setup docs: Remove requests install from JupyterLite REPL setup Sep 22, 2022
@matthewfeickert
Copy link
Member Author

The CI requires PR #2019 to go in first — c.f. #2019 (comment).

@matthewfeickert matthewfeickert force-pushed the docs/remove-requests-from-jupyterlite branch from c5f6c56 to d95357e Compare September 22, 2022 14:05
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 98.29% // Head: 98.29% // No change to project coverage 👍

Coverage data is based on head (de416d5) compared to base (de416d5).
Patch has no changes to coverable lines.

❗ Current head de416d5 differs from pull request most recent head d95357e. Consider uploading reports for the commit d95357e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2020   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          69       69           
  Lines        4529     4529           
  Branches      738      738           
=======================================
  Hits         4452     4452           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 27.51% <0.00%> (ø)
doctest 61.13% <0.00%> (ø)
unittests-3.10 96.31% <0.00%> (ø)
unittests-3.7 96.28% <0.00%> (ø)
unittests-3.8 96.33% <0.00%> (ø)
unittests-3.9 96.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit e2170c6 into main Sep 22, 2022
@matthewfeickert matthewfeickert deleted the docs/remove-requests-from-jupyterlite branch September 22, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants