Skip to content

Commit

Permalink
docs: Remove requests install from JupyterLite REPL setup (#2020)
Browse files Browse the repository at this point in the history
* To simplify things, remove the piplite install of requests from the JupyterLite REPL setup.
   - Given the async nature of Pyodide, requests isn't currently useful for examples using
     pyhf.contrib.utils.download. c.f. Issue #1775 for context.
  • Loading branch information
matthewfeickert authored Sep 22, 2022
1 parent de416d5 commit e2170c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/generate_jupyterlite_iframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
def main():
code = """\
import piplite
await piplite.install(["pyhf==0.7.0rc4", "requests"])
await piplite.install(["pyhf==0.7.0rc4"])
%matplotlib inline
import pyhf\
"""
Expand Down
2 changes: 1 addition & 1 deletion docs/jupyterlite.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Try out now with JupyterLite_
.. raw:: html

<iframe
src="https://jupyterlite.github.io/demo/repl/index.html?kernel=python&toolbar=1&code=import%20piplite%0Aawait%20piplite.install%28%5B%22pyhf%3D%3D0.7.0rc4%22%2C%20%22requests%22%5D%29%0A%25matplotlib%20inline%0Aimport%20pyhf"
src="https://jupyterlite.github.io/demo/repl/index.html?kernel=python&toolbar=1&code=import%20piplite%0Aawait%20piplite.install%28%5B%22pyhf%3D%3D0.7.0rc4%22%5D%29%0A%25matplotlib%20inline%0Aimport%20pyhf"
width="100%"
height="500px"
></iframe>
Expand Down

0 comments on commit e2170c6

Please sign in to comment.