Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update JAX backend normal docstring to jax v0.3.2 returns #1813

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 17, 2022

Description

Update jax backend normal docstring examples to jax v0.3.2+ DeviceArray return of showing weak_type=True. This is the same sort of thing that was required for PR #1584.

So now after the update

$ python -m pip list | grep jax
jax                               0.3.2
jaxlib                            0.3.2
jupyter-server-mathjax            0.2.3
$ pytest src/pyhf/tensor/jax_backend.py

passes the doctest. 👍

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update jax backend normal docstring examples to jax v0.3.2+
DeviceArray return of showing `weak_type=True`.

* Update jax backend normal docstring examples to jax v0.3.2+
DeviceArray return of showing `weak_type=True`.
@matthewfeickert matthewfeickert added docs Documentation related fix A bug fix labels Mar 17, 2022
@matthewfeickert matthewfeickert self-assigned this Mar 17, 2022
@matthewfeickert matthewfeickert added the tests pytest label Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1813 (d11d319) into master (f862b8c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1813   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files          64       64           
  Lines        4270     4270           
  Branches      719      719           
=======================================
  Hits         4191     4191           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.25% <ø> (ø)
doctest 60.60% <ø> (ø)
unittests 96.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/tensor/jax_backend.py 98.58% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f862b8c...d11d319. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 1884c6c into master Mar 17, 2022
@matthewfeickert matthewfeickert deleted the fix/fix-doctest branch March 17, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix tests pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant