Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update JAX backend poisson docstring to jax v0.2.20 returns #1584

Merged
merged 4 commits into from
Sep 3, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 3, 2021

Description

Required to get PR #1583 done. JAX v0.2.20 was released 35 minutes ago while I was working on PR #1583.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update jax backend poisson docstring examples to jax v0.2.20+ DeviceArray return of showing `weak_type=True`

@matthewfeickert matthewfeickert added docs Documentation related fix A bug fix labels Sep 3, 2021
@matthewfeickert matthewfeickert self-assigned this Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #1584 (ebcd468) into master (c5b5c58) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1584   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          63       63           
  Lines        4050     4050           
  Branches      576      576           
=======================================
  Hits         3957     3957           
  Misses         54       54           
  Partials       39       39           
Flag Coverage Δ
contrib 25.43% <ø> (ø)
unittests 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/tensor/jax_backend.py 97.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b5c58...ebcd468. Read the comment docs.

@matthewfeickert matthewfeickert changed the title docs: Update JAX backend docstrings to jax v0.2.20 returns docs: Update JAX backend poisson docstring to jax v0.2.20 returns Sep 3, 2021
@matthewfeickert matthewfeickert merged commit 4ed0148 into master Sep 3, 2021
@matthewfeickert matthewfeickert deleted the docs/update-docstrings-for-jaxlib branch September 3, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant