Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update codecov-action to v2 API #1623

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 11, 2021

Description

Requires PR #1622 to go in first.

Update codecov/codecov-action to v2 API as v1 API is being deprecated in 2022.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update to codecov/codecov-action v2
   - c.f. https://github.com/codecov/codecov-action
   - Update `file` -> `files`

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions chore Other changes that don't modify src or test files labels Oct 11, 2021
@matthewfeickert matthewfeickert self-assigned this Oct 11, 2021
@matthewfeickert matthewfeickert force-pushed the ci/update-codecov-action branch from 5b93231 to 71e0e44 Compare October 11, 2021 07:40
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #1623 (e5f6728) into master (7ecaa63) will not change coverage.
The diff coverage is n/a.

❗ Current head e5f6728 differs from pull request most recent head cfd3e13. Consider uploading reports for the commit cfd3e13 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1623   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          63       63           
  Lines        4048     4048           
  Branches      576      576           
=======================================
  Hits         3955     3955           
  Misses         54       54           
  Partials       39       39           
Flag Coverage Δ
contrib 25.44% <ø> (ø)
unittests 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc4b24a...cfd3e13. Read the comment docs.

@matthewfeickert matthewfeickert force-pushed the ci/update-codecov-action branch from e5f6728 to cfd3e13 Compare October 12, 2021 20:31
@matthewfeickert matthewfeickert marked this pull request as ready for review October 12, 2021 20:32
@matthewfeickert
Copy link
Member Author

Semantic PRs is currently down zeke/semantic-pull-requests#162, so can ignore the fact that the check is still "Expected"

@matthewfeickert matthewfeickert merged commit e47b1cf into master Oct 12, 2021
@matthewfeickert matthewfeickert deleted the ci/update-codecov-action branch October 12, 2021 20:51
matthewfeickert added a commit that referenced this pull request Oct 12, 2021
* Report coverage to Codecov without using a secret Codecov token
   - c.f. codecov/codecov-action#29 (comment)
   - Effectively reverts Codecov logic part of PR #1622
* Ensure codecov/codecov-action v2 used
   - Amends PR #1623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant