Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect test 1300 from ROOT without C++17 (or, at least, without std::optional). #1383

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Protect test 1300 from ROOT without C++17 (or, at least, without std::optional). #1383

merged 1 commit into from
Mar 23, 2022

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski linked an issue Mar 23, 2022 that may be closed by this pull request
Test failure with 1.8.0 (1300-awkward-to-cpp-converter-with-cling) #1382
Closed
@jpivarski jpivarski enabled auto-merge (squash) March 23, 2022 22:31
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1383 (56c49ba) into main (b2fd2be) will decrease coverage by 0.85%.
The diff coverage is 54.42%.

Impacted Files Coverage Δ
src/awkward/_v2/_connect/cling.py 0.00% <0.00%> (ø)
src/awkward/_v2/_connect/cuda/__init__.py 0.00% <0.00%> (ø)
src/awkward/_v2/_lookup.py 97.50% <0.00%> (ø)
src/awkward/_v2/_prettyprint.py 66.09% <0.00%> (+2.29%) ⬆️
src/awkward/_v2/identifier.py 55.69% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_from_jax.py 75.00% <0.00%> (ø)
src/awkward/_v2/operations/convert/ak_to_jax.py 75.00% <0.00%> (ø)
src/awkward/_v2/operations/io/ak_from_parquet.py 75.00% <0.00%> (ø)
src/awkward/_v2/operations/io/ak_to_parquet.py 75.00% <0.00%> (ø)
src/awkward/_v2/operations/structure/ak_firsts.py 75.00% <0.00%> (ø)
... and 152 more

@jpivarski jpivarski merged commit 6d2801a into main Mar 23, 2022
@jpivarski jpivarski deleted the jpivarski/protect-test_1300-from-ROOT-without-cpp17 branch March 23, 2022 23:05
@jpivarski jpivarski mentioned this pull request Apr 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure with 1.8.0 (1300-awkward-to-cpp-converter-with-cling)
1 participant
@jpivarski