-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure with 1.8.0 (1300-awkward-to-cpp-converter-with-cling) #1382
Comments
Oh: your ROOT wasn't compiled with C++17 support, so when this test tries to JIT-compile (I'm only recognizing this as the error because it happened to me before I recompiled my ROOT, then it didn't occur to me that having these in as tests would run into the same problem for somebody else.) Offhand, do you know of a way to determine from ROOT which C++ revision it uses? |
I don't think that's possible - I enforce C++17 on the Arch Linux ROOT package - you can find the PKGBUILD here. On your second question - I think you can ask the root compiler to spit out |
@kgizdov, in your ROOT environment (PyROOT, actually), what do you get when you try this: >>> import ROOT
>>> hasattr(ROOT.std, "optional")
True I don't know how to ask for |
So this line should ensure C++17: In mine, I had to pass Anyway, what's failing in the tests is that it can't find @pytest.mark.skipif(not cpp17, reason="ROOT was compiled without C++17 support") to those four tests with cpp17 = hasattr(ROOT.std, "optional") Even if it's a misnomer, if PyROOT doesn't find But I'd really like to know, on your system that doesn't find |
Indeed, |
Then it might be a misnomer, but the important thing is whether I had thought that ROOT would take the latest C++ standard available by a compiler, because it's only limiting what code can be compiled with that ROOT (since C++ standards are backward-compatible, so far). I was surprised that I had to explicitly tell it. |
Version of Awkward Array
1.8.0
Description and code to reproduce
Test failures on Arch Linux x86_64, GCC 11.2.0, ROOT 6.26.00:
The text was updated successfully, but these errors were encountered: