Blacklight 8 update try2 bootstrap5 #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [sinatra](https://github.com/sinatra/sinatra) from 4.0.0 to 4.1.0. - [Changelog](https://github.com/sinatra/sinatra/blob/main/CHANGELOG.md) - [Commits](sinatra/sinatra@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: sinatra dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…_frontend upgrades to match This doesn't actually WORK yet, we have to fix some things, but updated dependencies
…nt architecture for BL8
…tomize, we prefer a thicker one
…latest blacklight 8.6.1, not avail
Merged
jrochkind
force-pushed
the
blacklight_8_update_try2_bootstrap5
branch
from
4ca236a to
927ac90
Compare
… design for in BL 7
jrochkind
force-pushed
the
blacklight_8_update_try2_bootstrap5
branch
from
0488d7a to
4408247
Compare
jrochkind
force-pushed
the
blacklight_8_update_try2_bootstrap5
branch
from
bf8f2a2 to
9f9f886
Compare
Closed
eddierubeiz
approved these changes
Dec 2, 2024
eddierubeiz
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of branch
bootstrap5in #2775, but also adds upgrade to Blacklight 8.There are some things -- partiuclar modals for the facets 'more' dialog -- it was hard to get to display right in Blacklight 7 with Bootstrap 5 (and also in Blacklight 8 with Bootstrap 4!), so doing both at once gets around it.
A separate PR to make it easier to review though, this PR should be somewhat manageable to review, as opposed to #2775 with Bootstrap 5 that is monstrous!