Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to bootstrap 5 #2775

Merged
merged 71 commits into from
Dec 3, 2024
Merged

migrate to bootstrap 5 #2775

merged 71 commits into from
Dec 3, 2024

Conversation

jrochkind
Copy link
Contributor

@jrochkind jrochkind commented Nov 4, 2024 •
edited
Loading

Separate PR from #2788 for ease of review (of that one! This one is saldy monstrous) . But should be merged and released together -- simultaneous upgrade to bootstrap 5 and Blacklight 8, since upgrading just one at a time is hard to get around some display bugs.

@jrochkind
update bootstrap to 5, first step, there will be lots broken
0db662a
@jrochkind
use version of popper for Bootstrap 5
33b1ea5
@jrochkind
no need to manually import popper and assign to global, bootstrap 5 j…
a32e92d 
…ust imports it normal
@jrochkind
bootstrap 4=>5 variables and classes necessary for compilation
8f041a5
@jrochkind
Some Bootstrap 4=>5 migration done automatically by tool
0a03698 
Includes some mistakes that will have to be fixed.

used https://github.com/coliff/bootstrap-5-migrate-tool
@jrochkind
revert wrong class rename by bootstrap-5-migrate-tool
85055c7
@jrochkind
revert some over-eager changes of data attributes for bootstrap5, the…
4ea502e 
…se weren't bootstrap but our own custom
@jrochkind
fix dropdown component to use new data-bs-toggle for bootstrap 5
a02b2bb
@jrochkind
update viewer alert for bootstrap 5
8605e34
@jrochkind
fix button-like spacing for bootstrap 5
ea8e7b8
@jrochkind
fix button append for bootstrap 5
b3455b2
@jrochkind
set grid-gutter-width to match bootstrap 4's larger one, as that is o…
f17dd50 
…ur design and other things match
@jrochkind
fix spacing for bootstrap 5
500b723
@jrochkind
update sr-only=>visually-hidden for bootstrap 5
be9e5b7
@jrochkind
fix spec for new bootstrap 5 attr name
45b2c84
@jrochkind
fix JS to click on tab using new Bootstrap 5 attr name
b7c8d93
@jrochkind
undo overreach from Bootstrap 5 migration, this is our own data attr
d82f224
@jrochkind
update JS for Bootstrap 5 data-bs-toggle
0804941
@jrochkind
fix OH share link modal JS for bootstrap 5
fadb5d8
@jrochkind
fix input-group for Bootstrap 5
4f91d04
@jrochkind
fix spec for bootstrap 5 class names
b1cf537
@jrochkind
For bootstrap5 replace custom-select with form-select
db7f967
@jrochkind
simple_form default config for bootstrap 5
8eea722
@jrochkind
customized somewhat more padding
c900753
@jrochkind
For bootstrap5, custom-select turns into form-select
06a6d0a
@jrochkind
get capybara to wait for field to be added
97cbdb5
@jrochkind
remove input-group-append that get in the way in Bootstrap 5
1cd6c8d
@jrochkind
remove input-group-append and input-group-prepend classes no longer n…
8bbdd8e 
…eeded in Bootstrap 5, and which can sometimes cause display problems with misaligned edges
@jrochkind
Merge branch 'master' into bootstrap5
0f3659d
@jrochkind
remove stylesheet references to input-group-append and -prepend when …
51dd8e1 
…those classes are no longer used. I think these were workarounds to bootstrap 4 bugs we no longer need.
@jrochkind
mr- turns to me- for bootstrap 5
c9bd729
@jrochkind
Merge branch 'master' into bootstrap5
0fa384e
@jrochkind
fix admin navbar for bootstrap 5
eb2495d
@jrochkind
make badge padding match bootstrap 4
7241e3d
@jrochkind
fix pagination for bootstrap 5 to match what we had before
2f9fcd9
@jrochkind
make rounded pill match bootstrap 4
9077e89
@jrochkind
use mb-4 for more spacing between fields instead of mb-3
ad1ce3d
@jrochkind
make 'you searched for' label show up again in bootstrap 5
94c09ee
@jrochkind
Merge branch 'master' into bootstrap5
2cf55cc
@jrochkind
another try at making form look like bootstrap 4
7e33ca5
@jrochkind
fix custom radio wrapping
874b60b
@jrochkind
reduce gap in admin form input
5c748c0
@jrochkind
fix slide down search options for bootstrap 5, to look as they did in…
6a49769 
… bootstrap 4
@jrochkind
fix image next to text layout
d744440
@jrochkind
bootstrap links back to bootstrap 4 default of not underlined by defa…
173cb54 
…ult, since our CSS is built on top of this default, this is easiest for now
@jrochkind
badge-warning to text-bg-warning for bootstrap 4 to 5
e117d53
@jrochkind
badge-danger to text-bg-danger for bootstrap 5 upgrade
56b83de
@jrochkind
badge-pill to rounded-pill for bootstrap 5 upgrade
b57d00e
@jrochkind
badge fixes for bootstrap 5
4e0daf1
@jrochkind
properly activate Bootstrap 5 popovers and tooltips
85246c1
@jrochkind
fix attributes on citation popover for bootstrap 5
754d35d
@jrochkind
keep menu away from edge in bootstrap5
1117f87
@jrochkind
adjust colors for bootstrap5 to be brand appropriate, look good, acce…
50fbd68 
…ssible contrast. Especially for alerts
@jrochkind
fix custom button hover for bootstrap6
f64ee37
@jrochkind jrochkind mentioned this pull request Nov 20, 2024
Merged
@jrochkind jrochkind changed the title WIP migrate to bootstrap 5 migrate to bootstrap 5 Nov 20, 2024
@jrochkind jrochkind marked this pull request as ready for review December 3, 2024 16:12
@jrochkind jrochkind merged commit 2c083fd into master Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddierubeiz eddierubeiz eddierubeiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrochkind @eddierubeiz