Support labels for "repeated" field groups #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test? |
|
I think I can (I've modified the test code) but I don't know how to run tests for this bundle. How should I set up my environment? I do have phpunit and my fork in the vendors folder of some Symfony2 project, but when I run (sorry, I'm quite new to the symfony2 + composer + phpunit world :)) UPDATE 2012-07-24: figured it out. added tests in same commit (and updated my author name and email). Sorry for the messy process. |
|
+1 on this one :) |
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FormExtractor should support standard Symfony functionality as the "repeated" field group.
This has been suggested before (in e.g. PR #19) but rejected because it's only cleanly supportable in Symfony 2.1, whiich is now nearing completion.
The code is getting a little ugly and I could rewrite it into a
switchstatement if you think that's right.