Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Repeated Form Type #19

Closed
wants to merge 3 commits into from
Closed

Add Support for Repeated Form Type #19

wants to merge 3 commits into from

Conversation

AlexKa
Copy link
Contributor

@AlexKa AlexKa commented Jan 13, 2012

Hey,

labels for repeated form types are currently not translated.
-> I implemented a quick update.

Hopefully, it is useful for you.

Regards,
Alex

@AlexKa AlexKa closed this Jan 13, 2012
@schmittjoh
Copy link
Owner

Why did you close this?

@AlexKa
Copy link
Contributor Author

AlexKa commented Jan 15, 2012

I took a deeper look to the problem, and found that it does not make sense to fix the issue by improving this bundle as it is primarily a symfony design problem:

  • first_name/last_name is not the label, but the key of the property in the first place; however when label option is not set, it is also used as label. But it is always used as html id, which i find should not be translated at all.

Currently the repeated type is not well in symfony 2.0 branch designed:
https://github.com/symfony/symfony/blob/2.0/src/Symfony/Component/Form/Extension/Core/Type/RepeatedType.php

However it will be fixed in symfony 2.1:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/Core/Type/RepeatedType.php

Here you will be able to add an label via the 'first_options' and 'second_options'.

=> In my optionion the plugin should be changed for 2.1 compatibility, when 2.1 is ready
=> I closed this pull request

@schmittjoh
Copy link
Owner

Makes sense. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants