Drop symfony < 3.4 and < 4.3 for 4.x #520
Conversation
|
@franmomu Thanks for your PR! Looks good, but will take some time to be reviewed. @schmittjoh @gnat42 I'm fine with dropping support for old versions and doing some cleanup... what about you? |
Sure! Let me write some comments in some of the changes to make it easier. |
|
|
||
| /** | ||
| * @Route("/api", service="jms_translation.controller.api_controller") | ||
| * @Route("/api") |
There was a problem hiding this comment.
This is a deprecation for Route and Method from SensioFrameworkExtraBundle, because of removing the service option, I had to defined these aliases too.
| @@ -63,13 +63,6 @@ public function buildForm(FormBuilder $builder, array $options) | |||
| 'label' => false, | |||
| 'attr' => array('placeholder' => /** @Desc("Field with a placeholder but no label") */ 'form.placeholder.text.but.no.label') | |||
| )) | |||
| ->add('field_with_choice_as_values', 'choice', array( | |||
There was a problem hiding this comment.
franmomu
force-pushed
the
drop_symfony_versions
branch
2 times, most recently
from
455cb12 to
c4219ff
Compare
|
It makes sense at this point to start dropping some of those. I haven't reviewed the PR closely though I did skim through the changes and it looked fine to me. However I'd suggest that if this is done you perhaps make it a major release number bump due to the break. |
|
@gnat42 I do not see bc breaks, can you point me to it? (dropping supported version should not be considered as a BC break, see this blog post from the doctrine team https://www.doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html) |
|
@goetas Interesting. I can see their point. The only reason I disagree (but ultimately don't care which way you go with this), is semantic version not only helps the computer know what version and allows you to stick to a particular one, but it also signals people that something has changed. True if you bump the minimum up it doesn't break and composer will ignore new versions but then people will be hmm why do I have x.y.z and and not x.y.z2... and have to dig a bit. A major version bump tells you something has changed without digging is all. Feel free to merge and release whatever version you like. |
|
If there are not BC breaks I would release a minor version. To be compatible with Symfony 5 there are some changes that won't be BC like removing |
|
@franmomu can you please rebase your pr? |
franmomu
force-pushed
the
drop_symfony_versions
branch
from
c4219ff to
5c4c455
Compare
franmomu
force-pushed
the
drop_symfony_versions
branch
from
5c4c455 to
9b6445c
Compare
Description
EDIT: I've removed some changes I had made (cleaning up) so there are fewer changes and those changes can be applied later with a CS Fixer.