Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-registration of the command #481

Closed
wants to merge 2 commits into from
Closed

Auto-registration of the command #481

wants to merge 2 commits into from

Conversation

pdias
Copy link

@pdias pdias commented Feb 23, 2018

Deprecated since Symfony 3.4 and won't be supported in 4.0. Use PSR-4 based service discovery instead.

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets
License Apache2

Description

A few sentences describing the overall goals of the pull request's commits.

Todos

  • Tests
  • Documentation
  • Changelog

Deprecated since Symfony 3.4 and won't be supported in 4.0. Use PSR-4 based service discovery instead.
@@ -164,5 +164,16 @@
<argument>%kernel.debug%</argument>
<tag name="twig.extension" />
</service>

<!-- Command -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate comment.


<!-- Command -->
<!-- Command -->
<service id="JMS\TranslationBundle\Command\ExtractTranslationCommand" class="JMS\TranslationBundle\Command\ExtractTranslationCommand">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure you need to specify the class if it's the same as the id.

@goetas
Copy link
Collaborator

goetas commented Feb 24, 2020

Solved in #520

@goetas goetas closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants