Xliff attributes rebased #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nyholm
commented
May 7, 2016
Nyholm
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | Same as #328 but with extra fixes |
| License | MIT |
- Configured loader for xlf to be the same as for xliff.
- Added XliffMessage to store:
* note-elements (children of trans-unit)
* attribute trans-unit('approved')
* attribute target('state').
- Added I/O passthrough of existing input, e.g. XliffMessage, in Updater.php.
- Modifications to XliffLoader and XliffDumper to use XliffMessage.
- Added tests.
| } | ||
| } else { | ||
| $m->addNote((string) $trans->note, isset($trans->note['from']) ? ((string) $trans->note['from']) : null); | ||
| } |
There was a problem hiding this comment.
why the test for the count? who cares if its 1 or more? Why not just foreach on $trans->note regardless of 1 or more?
There was a problem hiding this comment.
I think, what we actually is testing is is_array($this->note)
There was a problem hiding this comment.
so if they are testing is_array... but then else the block of code both does a cast to string, and an isset on the from. Which makes this part a bit confusing. If this is legitimately the best way to do what it is doing some inline comments would surely help future devs understand it better
There was a problem hiding this comment.
I've tested it now. It is the best way of doing it. I have added a comment about it.
|
Thanks for all the hard work |
This was referenced Jun 8, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.