Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep XLIFF attributes #147

Closed
Lumbendil opened this issue Sep 5, 2013 · 3 comments
Closed

Keep XLIFF attributes #147

Lumbendil opened this issue Sep 5, 2013 · 3 comments

Comments

@Lumbendil
Copy link

It'd be nice that this bundle, when regenerating an XLIFF file, it kept the attributes.

<trans-unit id="b95d03a2faceaf98932af3c912c19df68bdb2084" resname="Clave" approved="yes">
    <jms:reference-file line="26">Form/Type/UserEditType.php</jms:reference-file>
    <jms:reference-file line="26">Form/Type/UserRegisterType.php</jms:reference-file>
    <source>Clave</source>
    <target state="translated">Senha</target>
</trans-unit>

In this example, the state of translated and the approved are lost when regenerating the file.

@nixilla
Copy link

nixilla commented Oct 7, 2013

+1

@GabLeRoux
Copy link

I've been using this PR and I confirm it does keep approved="yes", Been using this within weblate and it works. I couldn't find a way to display resname in weblate sidebar thought. Thanks for this (This bundle really doesn't seem to be maintained anymore)

@Nyholm
Copy link
Collaborator

Nyholm commented Jun 10, 2016

Closed by #356

@Nyholm Nyholm closed this as completed Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants