Alerts without a "message" annotation don't show meaningful details in MetalK8s UI #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made to display alert message on UI when prometheus alerts annotation have any of description, summary or message field Refs: #2994 Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
Change made to add additional field for Prometheus alerts with any of description, summary or message field Refs: #2994 Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
Hello n1603,My role is to assist you with the merge of this Status report is not available. |
removed un-relaed change Refs: #2994 Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
ChengYanJin
reviewed
Jan 12, 2021
There was a problem hiding this comment.
Hello @n1603 ,
Thanks for creating the pull request!
The UI part looks good to me.
If you can squash the first and third commit into one would be great!
Changes made to display alert message on UI when prometheus alerts annotation have any of description, summary or message field Refs: #2994 Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
Change made to add additional field for Prometheus alerts with any of description, summary or message field Refs: #2994 Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
Changes made to display alert message on UI when prometheus alerts annotation have any of description, summary or message field Refs: #2994 Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
…nto development/2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component:
ui, tests
Context:
#2994
Summary:
Changes made to display alert message on UI when prometheus alerts annotation have any of description, summary or message field. Currently blank alert message shown for many of prometheus alerts in metalk8s UI.
Acceptance criteria:
Closes: #ISSUE_NUMBER