Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerts without a "message" annotation don't show meaningful details in MetalK8s UI #2994

Closed
gdemonet opened this issue Dec 21, 2020 · 6 comments · Fixed by #3038
Closed

Alerts without a "message" annotation don't show meaningful details in MetalK8s UI #2994

gdemonet opened this issue Dec 21, 2020 · 6 comments · Fixed by #3038
Labels
complexity:easy Something that requires less than a day to fix kind:bug Something isn't working severity:medium Medium impact (usability) on live deployments topic:monitoring Everything related to monitoring of services in a running cluster topic:ui UI-related issues

Comments

@gdemonet
Copy link
Contributor

gdemonet commented Dec 21, 2020 •
edited
Loading

I have installed metalk8s and all seems to work fine, except for Alert UI. I don't see alert message for some of the alert like KubeCPUOvercommit.

[...]

- alert: KubeCPUOvercommit
    annotations:
      description: Cluster has overcommitted CPU resource requests for Pods and cannot tolerate node failure.
      runbook_url: https://github.com/kubernetes-monitoring/kubernetes-mixin/tree/master/runbook.md#alert-name-kubecpuovercommit
      summary: Cluster has overcommitted CPU resource requests.

Originally posted by @n1603 in #2993

We should likely handle all known alert annotations to display the most relevant information to our users when an alert fires.
@gdemonet gdemonet added complexity:easy Something that requires less than a day to fix kind:bug Something isn't working severity:medium Medium impact (usability) on live deployments topic:monitoring Everything related to monitoring of services in a running cluster topic:ui UI-related issues labels Dec 21, 2020
@n1603
Copy link
Contributor

n1603 commented Dec 21, 2020 •
edited
Loading

@gdemonet, Thanks, this is how I handled this. : link, please let me know your feedback. Similar change for VolumeAlertsTab.js and update on monitoring test.

@gdemonet gdemonet mentioned this issue Dec 28, 2020
Merged
@NicolasT
Copy link
Contributor

@n1603 Could you create a PR to contribute your fixes? @ChengYanJin left some notes on the process at #2993 (comment). Thanks!

@n1603
Copy link
Contributor

n1603 commented Jan 12, 2021

@NicolasT, thanks. if fix helps, I will create PR after going through the process.

@n1603 n1603 mentioned this issue Jan 12, 2021
Closed
@n1603
Copy link
Contributor

n1603 commented Jan 12, 2021

some issue with my pr branch squash not working as expected, will re-create.

n1603 added a commit to n1603/metalk8s that referenced this issue Jan 12, 2021
@n1603
ui: Expand support Prometheus alerts message display
ed4844b 
Changes made to display alert message on UI when prometheus alerts annotation have any of description, summary or message field

Refs: scality#2994

Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
n1603 added a commit to n1603/metalk8s that referenced this issue Jan 12, 2021
@n1603
tests: Update monitoring test for alert
adf73bf 
Change made to add additional field for Prometheus alerts with any of description, summary or message field

Refs: scality#2994

Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
@n1603 n1603 mentioned this issue Jan 12, 2021
Closed
@n1603
Copy link
Contributor

n1603 commented Jan 12, 2021

PR : #3030

@ChengYanJin ChengYanJin mentioned this issue Jan 14, 2021
Merged
ChengYanJin pushed a commit that referenced this issue Jan 14, 2021
@n1603 @ChengYanJin
ui: Expand support Prometheus alerts message display
6b3cf9a 
Changes made to display alert message on UI when prometheus alerts annotation have any of description, summary or message field

Refs: #2994

Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
ChengYanJin pushed a commit that referenced this issue Jan 14, 2021
@n1603 @ChengYanJin
tests: Update monitoring test for alert
7805c96 
Change made to add additional field for Prometheus alerts with any of description, summary or message field

Refs: #2994

Signed-off-by: Ganesh Chaudhari <ganesh0407@gmail.com>
gdemonet pushed a commit that referenced this issue Jan 15, 2021
@n1603 @gdemonet
tools, tests: Also use 'description' of alerts
b985249 
Ensures alerts as retrieved by the rule_extractor tool (and in the
corresponding test that verifies a live deployment is in sync) can also
use `annotations.description` as a valid candidate for the "message" to
display.

Refs: #2994
See: adf73bf
@NicolasT
Copy link
Contributor

I believe this is now closed by #3038 (#3030).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:easy Something that requires less than a day to fix kind:bug Something isn't working severity:medium Medium impact (usability) on live deployments topic:monitoring Everything related to monitoring of services in a running cluster topic:ui UI-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alerts without message annotation no detail in UI scality/metalk8s
3 participants
@NicolasT @n1603 @gdemonet