Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI - Enhance application typing - kubernetes client and reducers #2999

Closed
JBWatenbergScality opened this issue Dec 24, 2020 · 0 comments · Fixed by #3002
Closed

UI - Enhance application typing - kubernetes client and reducers #2999

JBWatenbergScality opened this issue Dec 24, 2020 · 0 comments · Fixed by #3002

Comments

@JBWatenbergScality
Copy link
Contributor

JBWatenbergScality commented Dec 24, 2020 •
edited
Loading

Component:

UI, typing

Why this is needed:

This brings typesafety and enhanced developer experience to the project.

What should be done:

  • Add type definitions to ui/src/services/k8s/api.js
  • Add type definitions to ui/src/ducks/reducer.js
  • Type useSelector when it is being used with useSelector<RootState> or simply useTypedSelector

Test plan:

Run flow cli to ensure typing is correctly interpreted, navigate through the code base in your IDE and see if all references to kubernetes objects are correctly typed
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add kubernetes client typing to client wrapper
ecaf4ea 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add volume reducer typing
091e021 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add constant typing
cc23489 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add config and theme typing
88bf36f 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add pods reducer typing
604d898 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: start solutions reducer typing
6bc06c0 
Refs: #2999
@JBWatenbergScality JBWatenbergScality mentioned this issue Dec 24, 2020
Merged
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add kubernetes client typing to client wrapper
9526031 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add volume reducer typing
22d4b62 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add constant typing
79f9d92 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add config and theme typing
5a0ef0f 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: add pods reducer typing
f64a7a1 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 24, 2020
@JBWatenbergScality
ui: start solutions reducer typing
f9eda72 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: add a flow typed client generator
5dbe0d7 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: fix client generator and add a warning
415e869 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: add kubernetes client typing to client wrapper
3a22285 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: add volume reducer typing
919a3d2 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: add constant typing
1cab969 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: add config and theme typing
6316542 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: add pods reducer typing
2b08855 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: start solutions reducer typing
cc8ea05 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: add a flow typed client generator
afcfcf3 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: fix client generator and add a warning
5d32e97 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Dec 29, 2020
@JBWatenbergScality
ui: use generated metalk8s client and types
79cb860 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: add kubernetes client typing to client wrapper
6e03a09 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: add volume reducer typing
752761e 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: add constant typing
b44361e 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: add config and theme typing
695ae48 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: add pods reducer typing
3ba382d 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: start solutions reducer typing
f294a57 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: add pods reducer typing
c6ccbb8 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: start solutions reducer typing
7bd53d4 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: add a flow typed client generator
1014719 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: use generated metalk8s client and types
3e497da 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: Add kubernetes client typing to client wrapper
1ad8bb1 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: Add volume reducer typing
4da6521 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: Add constant typing
e3ca910 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: Add config and theme typing
f57849c 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: Add pods reducer typing
0b01fef 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: Start solutions reducer typing
f3198b1 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: Add a flow typed client generator
bc4445d 
The goal of this commit is to introduce a generator of a client based upon `@kubernetes/client` custom objects client from kubernetes `CustomResourceDefinition`.

The idea behind this is to have always up to date types definition for our custom resource definition and be in sync with the json schema contained within those definitions.

Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 8, 2021
@JBWatenbergScality
ui: Use generated metalk8s client and types
a886d3b 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 11, 2021
@JBWatenbergScality
ui: Use generated metalk8s client and types
aed514e 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 13, 2021
@JBWatenbergScality
ui: Add kubernetes client typing to client wrapper
df84f1b 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 13, 2021
@JBWatenbergScality
ui: Add volume reducer typing
af67406 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 13, 2021
@JBWatenbergScality
ui: Add constant typing
50dafc6 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 13, 2021
@JBWatenbergScality
ui: Add config and theme typing
42d26eb 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 13, 2021
@JBWatenbergScality
ui: Add pods reducer typing
3fa9c4e 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 13, 2021
@JBWatenbergScality
ui: Start solutions reducer typing
6c79055 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 13, 2021
@JBWatenbergScality
ui: Add a flow typed client generator
51a4d74 
The goal of this commit is to introduce a generator of a client based upon `@kubernetes/client` custom objects client from kubernetes `CustomResourceDefinition`.

The idea behind this is to have always up to date types definition for our custom resource definition and be in sync with the json schema contained within those definitions.

Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 13, 2021
@JBWatenbergScality
ui: Use generated metalk8s client and types
94e6124 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 18, 2021
@JBWatenbergScality
ui: Add kubernetes client typing to client wrapper
c01d9ce 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 18, 2021
@JBWatenbergScality
ui: Add volume reducer typing
e875195 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 18, 2021
@JBWatenbergScality
ui: Add constant typing
550c4da 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 18, 2021
@JBWatenbergScality
ui: Add config and theme typing
bbe82c3 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 18, 2021
@JBWatenbergScality
ui: Add pods reducer typing
1420c1f 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 18, 2021
@JBWatenbergScality
ui: Start solutions reducer typing
056857a 
Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 18, 2021
@JBWatenbergScality
ui: Add a flow typed client generator
3db0858 
The goal of this commit is to introduce a generator of a client based upon `@kubernetes/client` custom objects client from kubernetes `CustomResourceDefinition`.

The idea behind this is to have always up to date types definition for our custom resource definition and be in sync with the json schema contained within those definitions.

Refs: #2999
JBWatenbergScality added a commit that referenced this issue Jan 18, 2021
@JBWatenbergScality
ui: Use generated metalk8s client and types
0ed1ba9 
Refs: #2999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui - enhance flow typing scality/metalk8s
1 participant
@JBWatenbergScality