ui: Add pods reducer typing

Refs: #2999
scality · Jan 18, 2021 · 1420c1f · 1420c1f
1 parent f46450a
commit 1420c1f
Showing 1 changed file with 28 additions and 7 deletions.
diff --git a/ui/src/ducks/app/pods.js b/ui/src/ducks/app/pods.js
@@ -1,5 +1,8 @@
-import { call, put, takeLatest } from 'redux-saga/effects';
+//@flow
+import { V1ContainerStatus, V1Pod, V1PodList } from '@kubernetes/client-node/dist/gen/model/models';
+import { call, put, takeLatest, Effect } from 'redux-saga/effects';
 import * as CoreApi from '../../services/k8s/core';
+import type {APIResult} from '../../types';
 
 // Actions
 const FETCH_PODS = 'FETCH_PODS';
@@ -10,7 +13,25 @@ const defaultState = {
   list: [],
 };
 
-export default function reducer(state = defaultState, action = {}) {
+export type Pod = {
+  name: string,
+  namespace: string,
+  nodeName: string,
+  status: string,
+  startTime: string,
+  restartCount: number,
+  volumes: {
+    name: string,
+    persistentVolumeClaim: string,
+  }[],
+  containerStatuses: V1ContainerStatus[],
+}
+
+export type PodsState = {
+  list: Pod[]
+}
+
+export default function reducer(state: PodsState = defaultState, action: any = {}) {
   switch (action.type) {
     case SET_PODS:
       return { ...state, list: action.payload };
@@ -24,17 +45,17 @@ export const fetchPodsAction = () => {
   return { type: FETCH_PODS };
 };
 
-export const setPodsAction = (payload) => {
+export const setPodsAction = (payload: Pod[]) => {
   return { type: SET_PODS, payload };
 };
 
 // Sagas
-export function* fetchPods() {
+export function* fetchPods(): Generator<Effect, void, APIResult<V1PodList>> {
   const result = yield call(CoreApi.getPods);
   if (!result.error) {
     yield put(
       setPodsAction(
-        result.body.items.map((pod) => ({
+        result.body.items.map((pod: V1Pod) => ({
           name: pod.metadata.name,
           namespace: pod.metadata.namespace,
           nodeName: pod.spec.nodeName,
@@ -44,7 +65,7 @@ export function* fetchPods() {
             pod.status.containerStatuses && pod.status.containerStatuses.length
               ? pod.status.containerStatuses[0].restartCount
               : 0,
-          volumes: pod?.spec?.volumes?.map((volume) => ({
+          volumes: (pod?.spec?.volumes ?? []).map((volume) => ({
             name: volume.name,
             persistentVolumeClaim: volume?.persistentVolumeClaim?.claimName,
           })),
@@ -55,6 +76,6 @@ export function* fetchPods() {
   }
 }
 
-export function* podsSaga() {
+export function* podsSaga(): Generator<void, void, void> {
   yield takeLatest(FETCH_PODS, fetchPods);
 }