Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exclude rule for circular dependency #181

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

ashawley
Copy link
Member

Despite my effort in #126, the exclude rule was using the full scala version number, when it should only be the binary version, e.g. 2.12., and therefore failing to exclude.

> xmlJVM/test:dependencyTree
[info] org.scala-lang.modules:scala-xml_2.12:1.1.0-SNAPSHOT [S]
[info]   +-com.novocode:junit-interface:0.10
[info]   | +-junit:junit-dep:4.10
[info]   | | +-org.hamcrest:hamcrest-core:1.1 (evicted by: 1.3)
[info]   | | +-org.hamcrest:hamcrest-core:1.3
[info]   | | 
[info]   | +-org.scala-tools.testing:test-interface:0.5
[info]   | 
[info]   +-junit:junit:4.11
[info]   | +-org.hamcrest:hamcrest-core:1.1 (evicted by: 1.3)
[info]   | +-org.hamcrest:hamcrest-core:1.3
[info]   | 
[info]   +-org.apache.commons:commons-lang3:3.5
[info]   +-org.scala-lang:scala-compiler:2.12.4 [S]
[info]     +-org.scala-lang.modules:scala-xml_2.12:1.0.6 <--- !!!
[info]     +-org.scala-lang:scala-reflect:2.12.4 [S]
[info]     

@ashawley
Copy link
Member Author

With this change scala-xml is now excluded as a transitive dependency of the scala-compiler.

> xmlJVM/test:dependencyTree
[info] org.scala-lang.modules:scala-xml_2.12:1.1.0-SNAPSHOT [S]
[info]   +-com.novocode:junit-interface:0.10
[info]   | +-junit:junit-dep:4.10
[info]   | | +-org.hamcrest:hamcrest-core:1.1 (evicted by: 1.3)
[info]   | | +-org.hamcrest:hamcrest-core:1.3
[info]   | | 
[info]   | +-org.scala-tools.testing:test-interface:0.5
[info]   | 
[info]   +-junit:junit:4.11
[info]   | +-org.hamcrest:hamcrest-core:1.1 (evicted by: 1.3)
[info]   | +-org.hamcrest:hamcrest-core:1.3
[info]   | 
[info]   +-org.apache.commons:commons-lang3:3.5
[info]   +-org.scala-lang:scala-compiler:2.12.4 [S]
[info]     +-org.scala-lang:scala-reflect:2.12.4 [S]

Not that this makes a dime of a difference in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant