Fix circular dependency exclude rule #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs rebase now. this LGTM otherwise and I would suggest we merge in a few days if there are no objections |
ashawley
force-pushed
the
enable-test-forking
branch
from
99e5200 to
afeefa0
Compare
SethTisue
approved these changes
Feb 15, 2017
ashawley
force-pushed
the
enable-test-forking
branch
from
afeefa0 to
4f30084
Compare
|
I don't understand this PR: the title says "Enable test forking", but the patch removes Note that |
|
@lrytz I agree. This PR is totally confused. That it's enabled in the plugin maybe explains my misunderstanding. I'll rename this PR, and reword the commits. |
ashawley
force-pushed
the
enable-test-forking
branch
3 times, most recently
from
3e84847 to
4c3504d
Compare
* build.sbt (libraryDependencies): There's no evidence that SBT supports Ivy's exclude globbing. See Ivy documentation http://ant.apache.org/ivy/history/2.4.0/ivyfile/artifact-exclude.html
ashawley
force-pushed
the
enable-test-forking
branch
from
4c3504d to
006afa4
Compare
|
The fork setting is already removed by #145, so this is only the dependency exclude rule, now. |
ashawley
added a commit
to ashawley/scala-xml
that referenced
this pull request
Jan 10, 2018
Despite my effort in scala#126, the exclude rule was using the full scala version number, when it should only be the binary version, e.g. 2.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems there's no evidence that SBT supports Ivy's exclude globbing even though it was trying to be used to exclude
scala-xmlfromscala-compileras a test dependency. See Ivy documentation http://ant.apache.org/ivy/history/2.4.0/ivyfile/artifact-exclude.htmlThis will revert forking for test in #112.