Provide helper function for new Analysis format #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
reviewed
Apr 10, 2024
| @@ -299,7 +300,7 @@ object MixedAnalyzingCompiler { | |||
| output: Output, | |||
| outputJarContent: JarUtils.OutputJarContent, | |||
| earlyOutput: Option[Output], | |||
| earlyAnalysisStore: Option[AnalysisStore], | |||
| earlyAnalysisStore: Option[XAnalysisStore], | |||
There was a problem hiding this comment.
Why do you want to use an alias for AnalysisStore?
If it is not necessary (no name conflict) I would prefer not to use an alias, to avoid having different names for the same thing in different files.
There was a problem hiding this comment.
I might have confused AnslysisStore and FileAnalysisStore. Let me try to remove the alias.
| ec: ExecutionContext, | ||
| parallelism: Int, | ||
| ): XAnalysisStore = { | ||
| import sbt.internal.inc.{ FileAnalysisStore => Store } |
There was a problem hiding this comment.
Here as well, I think using FileAnalysisStore directly is clearer than the alias Store, which is quite ambiguous.
eed3si9n
force-pushed
the
wip/consistent
branch
from
69c1ab0 to
4be431d
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.