-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump scala-maven-plugin from 4.8.0 to 4.9.2 #6364
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6364 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 677 677
Lines 41799 41799
Branches 5709 5709
======================================
Misses 41799 41799 ☔ View full report in Codecov by Sentry. |
Minor warning message thrown in logs, when compilation on Scala 2.13 : It's repeatedly shown in logs. It's not a blocker issue though. |
2d8d2d1
to
2553f66
Compare
2553f66
to
5543797
Compare
# 🔍 Description ## Issue References 🔗 This pull request fixes # ## Describe Your Solution 🔧 - bump `scala-maven-plugin` from 4.8.0 to 4.9.2, with `zinc` bumped from 1.8.0(Nov 11, 2022) to 1.10.0(May 6, 2024) ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6364 from bowenliang123/scala-maven-490. Closes #6364 5543797 [Bowen Liang] bump scala-maven-plugin to 4.9.2 Authored-by: Bowen Liang <liangbowen@gf.com.cn> Signed-off-by: Bowen Liang <liangbowen@gf.com.cn> (cherry picked from commit c94f0d7) Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
Thanks, merged to master and branch-1.9. |
Good to see it land finally |
Yes, the main concern comes to the benefit with mordernizing the Zinc version. |
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
scala-maven-plugin
from 4.8.0 to 4.9.2, withzinc
bumped from 1.8.0(Nov 11, 2022) to 1.10.0(May 6, 2024)Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.