Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scala-maven-plugin from 4.8.0 to 4.9.2 #6364

Closed
wants to merge 1 commit into from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented May 6, 2024

🔍 Description

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

  • bump scala-maven-plugin from 4.8.0 to 4.9.2, with zinc bumped from 1.8.0(Nov 11, 2022) to 1.10.0(May 6, 2024)

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0f6d764) to head (2553f66).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6364   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         677     677           
  Lines       41799   41799           
  Branches     5709    5709           
======================================
  Misses      41799   41799           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenliang123 bowenliang123 marked this pull request as draft May 6, 2024 08:16
@bowenliang123
Copy link
Contributor Author

Minor warning message thrown in logs, when compilation on Scala 2.13 :
Error: -release is only supported on Java 9 and higher
(https://github.com/apache/kyuubi/actions/runs/8964924157/job/24623089910#step:8:138)

It's repeatedly shown in logs. It's not a blocker issue though.

@bowenliang123 bowenliang123 changed the title Bump scala-maven-plugin to 4.9.0 Bump scala-maven-plugin from 4.8.0 to 4.9.2 Jul 17, 2024
@bowenliang123 bowenliang123 marked this pull request as ready for review July 17, 2024 05:22
@bowenliang123 bowenliang123 self-assigned this Jul 23, 2024
@bowenliang123 bowenliang123 force-pushed the scala-maven-490 branch 2 times, most recently from 2d8d2d1 to 2553f66 Compare July 23, 2024 08:45
@bowenliang123 bowenliang123 added this to the v1.9.3 milestone Jul 30, 2024
bowenliang123 added a commit that referenced this pull request Jul 30, 2024
# 🔍 Description
## Issue References 🔗

This pull request fixes #

## Describe Your Solution 🔧

- bump `scala-maven-plugin` from 4.8.0 to 4.9.2, with `zinc` bumped from 1.8.0(Nov 11, 2022) to 1.10.0(May 6, 2024)

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6364 from bowenliang123/scala-maven-490.

Closes #6364

5543797 [Bowen Liang] bump scala-maven-plugin to 4.9.2

Authored-by: Bowen Liang <liangbowen@gf.com.cn>
Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
(cherry picked from commit c94f0d7)
Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
@bowenliang123 bowenliang123 deleted the scala-maven-490 branch July 30, 2024 05:30
@bowenliang123
Copy link
Contributor Author

Thanks, merged to master and branch-1.9.

@yaooqinn
Copy link
Member

Good to see it land finally

@bowenliang123
Copy link
Contributor Author

bowenliang123 commented Jul 30, 2024

Yes, the main concern comes to the benefit with mordernizing the Zinc version.
Since last review, the Zinc has been bumped from 1.9.x to 1.10.x used with in the maven plugin. Zinc 1.10 brings the new analysis format for much faster speed in reading and writing, see benchmark in sbt/zinc#1326 .
The compilation warning ( #6364 (comment) ) still occurs when compiling on JDK 8 + Scala 2.13, but it's not a blocker issue. And furthermore, let's see whether #6571 helps in this case for separating parameter running on JDK 9+ with compiler plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants