[1.x] Generate AbstractZincFile
during -sourcepath
workflow
#1309
+40
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1304, #963
Issue
zinc/internal/compiler-bridge/src/main/scala/xsbt/API.scala
Line 62 in 5eb0de1
In certain codepath,
unit.source.file
is aPlainFile
, which causes aMatchError
.Fix
When
unit.source
is built, convertunit.source.file
toAbstractZincFile
.Validating the fix
The PR includes reproduction scripted test by lrytz. The test passes after the fix.