[1.x] Emit SourceInfos when incremental compilation fails
#1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendseeker
commented
Dec 9, 2023
internal/compiler-interface/src/main/java/xsbti/AnalysisCallback.java
Outdated
Show resolved
Hide resolved
Friendseeker
changed the title
SourceInfos when incremental compilation failsSourceInfos when incremental compilation fails
adpi2
reviewed
Dec 11, 2023
internal/zinc-core/src/main/scala/sbt/internal/inc/Incremental.scala
Outdated
Show resolved
Hide resolved
Friendseeker
commented
Dec 12, 2023
Friendseeker
force-pushed
the
build-source-info
branch
from
7884509
to
fa99c37
Compare
|
@adpi2 Reopened this PR and added a unit test. @eed3si9n c.c. #932 (comment) for reason for revisiting this PR. I am thinking if this can be merged along with #1309 as both involves adding |
eed3si9n
approved these changes
Sep 27, 2024
|
LGTM. could you squash the commits and add problem and solution descriptions in the commit message plz? |
Friendseeker
changed the title
SourceInfos when incremental compilation failsSourceInfos when incremental compilation fails
Friendseeker
force-pushed
the
build-source-info
branch
from
1f2495e
to
ee301d5
Compare
Zinc does not provide a way to surface list of all problems present in a codebase. This PR builds SourceInfos in Analysis Callback and in `handleErrors`, the compiler bridge then throws an exception containing the SourceInfos so build tools like sbt can access the informations. Closes sbt#932
Friendseeker
force-pushed
the
build-source-info
branch
from
ee301d5
to
2855609
Compare
|
@eed3si9n Squashed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #932 via building
SourceInfosfrom analysis callback and pass them tohandleErrorsinCompilerBridge.scala.c.c. @adpi2