Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing transitive dependency on kotlinpoet #584

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Nov 27, 2020

What's done:

  • Made kotlinpoet optional=true

This pull request closes #571. The fundamental problem here is that we have code/docs generation in main source set, and these classes are included in the jar. We can exclude dependencies when adding diktat-rules in plugins' poms, but more correct solution would be to extract codegen utils to a separate maven module (opened #592 or this).

### What's done:
* Made kotlinpoet optional=true
@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #584 (c3f67c9) into master (27b7973) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #584   +/-   ##
=========================================
  Coverage     80.82%   80.82%           
  Complexity     1712     1712           
=========================================
  Files            87       87           
  Lines          4385     4385           
  Branches       1351     1351           
=========================================
  Hits           3544     3544           
  Misses          298      298           
  Partials        543      543           
Flag Coverage Δ Complexity Δ
unittests 80.82% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b7973...c3f67c9. Read the comment docs.

Copy link
Collaborator

@kentr0w kentr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit dc1ba8d into master Dec 3, 2020
@petertrr petertrr deleted the bugfix/remove-transitive-dependencies#571 branch December 3, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unneeded transitive dependencies from runtime
3 participants