Removing transitive dependency on kotlinpoet #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Made kotlinpoet optional=true
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
=========================================
Coverage 80.82% 80.82%
Complexity 1712 1712
=========================================
Files 87 87
Lines 4385 4385
Branches 1351 1351
=========================================
Hits 3544 3544
Misses 298 298
Partials 543 543
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #571. The fundamental problem here is that we have code/docs generation in main source set, and these classes are included in the jar. We can exclude dependencies when adding
diktat-rulesin plugins' poms, but more correct solution would be to extract codegen utils to a separate maven module (opened #592 or this).