Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate generation phase for docs #592

Closed
petertrr opened this issue Nov 30, 2020 · 1 comment · Fixed by #645
Closed

Create separate generation phase for docs #592

petertrr opened this issue Nov 30, 2020 · 1 comment · Fixed by #645
Labels
documentation Improvements or additions to documentation infrastructure Issues related to building the project, CI/CD, deployments etc.

Comments

@petertrr
Copy link
Member

I'm starting to think that we need a separate file for such tasks with documentation in order not to run them during every build, maybe in a separate maven profile. But it can be done later in a separate PR.

Originally posted by @petertrr in #586 (comment)

@petertrr petertrr added infrastructure Issues related to building the project, CI/CD, deployments etc. documentation Improvements or additions to documentation labels Nov 30, 2020
@petertrr
Copy link
Member Author

petertrr commented Dec 1, 2020

The fundamental problem here is that we have code/docs generation in main source set, and these classes are included in the jar. We can exclude dependencies when adding diktat-rules in plugins' poms, but more correct solution would be to extract codegen utils to a separate maven module (opened #592 or this).

originally posted: #584 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation infrastructure Issues related to building the project, CI/CD, deployments etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant