Fix: CLASS_SHOULD_NOT_BE_ABSTRACT breaks code when abstract class implements an interface #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1200 +/- ##
============================================
- Coverage 84.21% 84.20% -0.02%
Complexity 2514 2514
============================================
Files 103 103
Lines 7070 7070
Branches 1910 1911 +1
============================================
- Hits 5954 5953 -1
Misses 333 333
- Partials 783 784 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
approved these changes
Jan 31, 2022
| @@ -35,6 +36,7 @@ class AbstractClassesRule(configRules: List<RulesConfig>) : DiktatRule( | |||
|
|
|||
| // If an abstract class extends another class, than that base class can be abstract too. | |||
| // Then this class must have `abstract` modifier even if it doesn't have any abstract members. | |||
| // Class also must have `abstract` modifier if it implements interface | |||
There was a problem hiding this comment.
Suggested change
| // Class also must have `abstract` modifier if it implements interface | |
| // Class also can have `abstract` modifier if it implements interface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
abstractmodifier if it implements interface, don't trigger on such cases