Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLASS_SHOULD_NOT_BE_ABSTRACT breaks code when abstract class implements an interface #1173

Closed
petertrr opened this issue Jan 17, 2022 · 1 comment · Fixed by #1200
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@petertrr
Copy link
Member

Describe the bug

interface I {
    fun foo()
}

abstract class A : I  // diktat raises CLASS_SHOULD_NOT_BE_ABSTRACT, changes `abstract` to `open` and breaks compilation

class B : A() {
    override fun foo() {}
}

Observed behavior

Diktat raises CLASS_SHOULD_NOT_BE_ABSTRACT, changes abstract to open and breaks compilation

Environment information

  • diktat version: 1.0.1
@petertrr petertrr added the bug Something isn't working label Jan 17, 2022
@orchestr7 orchestr7 added this to the 1.0.3 milestone Jan 24, 2022
@orchestr7 orchestr7 assigned orchestr7 and kgevorkyan and unassigned orchestr7 Jan 24, 2022
@orchestr7
Copy link
Member

@kgevorkyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants