Fix: AbstractClassesRule should also take properties into account #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fix logic * Add tests
kgevorkyan
approved these changes
Nov 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #1102 +/- ##
=========================================
Coverage 83.40% 83.41%
Complexity 2458 2458
=========================================
Files 102 102
Lines 6141 6143 +2
Branches 1840 1840
=========================================
+ Hits 5122 5124 +2
Misses 274 274
Partials 745 745
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Which rule and warnings did you add?
This pull request closes #1100