Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLASS_SHOULD_NOT_BE_ABSTRACT: abstract fields are ignored #1100

Closed
orchestr7 opened this issue Nov 8, 2021 · 0 comments · Fixed by #1102
Closed

CLASS_SHOULD_NOT_BE_ABSTRACT: abstract fields are ignored #1100

orchestr7 opened this issue Nov 8, 2021 · 0 comments · Fixed by #1102
Assignees
@petertrr
Labels
bug Something isn't working

Comments

@orchestr7
Copy link
Member 

abstract class BaseUsesProcessor() {
    // Store uses by file
    abstract val a: String
    
    fun foo() {}
}

is incorrectly treated as NON abstract class
@orchestr7 orchestr7 added the bug Something isn't working label Nov 8, 2021
@orchestr7 orchestr7 changed the title CLASS_SHOULD_NOT_BE_ABSTRACT: CLASS_SHOULD_NOT_BE_ABSTRACT: abstract fields are ignored Nov 8, 2021
@petertrr petertrr mentioned this issue Nov 8, 2021
Merged
petertrr added a commit that referenced this issue Nov 8, 2021
@petertrr
Fix: AbstractClassesRule should also take properties into account (#1102
1dd9230 
)

### What's done:
* Fix logic
* Add tests

Closes #1100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petertrr petertrr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: AbstractClassesRule should also take properties into account saveourtool/diktat
2 participants
@petertrr @orchestr7