Fixup smoke test for FindClusters #9641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the smoke test in
test_find_clusters.R
to accommodate variability in label assignments given byFindClusters
across different systems.On 14/01/2024, the maintainers of Seurat were contacted by CRAN with the following message:
Dear maintainer,
Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_Seurat.html.
Please correct before 2025-01-28 to safely retain your package on CRAN.
There is a check service for M1mac issues: see
https://www.stats.ox.ac.uk/pub/bdr/M1mac/README.txt .
However, it is running a much older version of the OS
and toolchain -- and the latter often matters.
The CRAN Team
tl;dr—we have until 2025/01/28 to resolve the M1mac errors currently being thrown by the CRAN package checks for Seurat:
I'm not totally sure what's causing the difference but I was able to reproduce the error on my local machine (M3mac) after adjusting my environment some. If we're unhappy with this variability I can try to investigate further but for now, I'm pretty confident that this update will resolve the issue. The fix is simple enough, instead of spot-checking the cluster labels for specific cells, the test now checks:
Do we think it's worth introducing a tolerance onto the cluster size check? 🤔
Once it has been approved and merged I will immediately start the process of releasing Seurat 5.2.1 to CRAN 🚀