-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add violin raster #5076
add violin raster #5076
Conversation
Hi @samuel-marsh, thanks for the PR! We would want to limit the dependencies as much as possible. For rasterization elsewhere, we rely on scattermore. Would it be possible to rely here on that instead? |
Hi @saketkc It certainly doesn't look bad without the additional position if you're really looking it does appear a little off. If you guys are ok with it though I can definitely modify the PR. Best, |
Thanks Sam! Do you have an example I could look at? Just want to avoid adding another dependency if possible. |
Hey @saketkc so here is quick example using the SeuratData hcabm40k dataset because has decent number of points. A few notes: --Even in this relatively small dataset scattermore is definitely way faster actually rendering the plot which is part of desire to rasterize in first place. Didn't time it, but very noticeable. --The file size of scattermore plot is also quite a bit smaller even in this small dataset though both are far cry from vector form. In the plots described below: Vector Form (p7): 2.3MB If there isn't way to make scattermore offset things when split then overall may not be worth the trouble of the additional dependencies just to add raster option for Best,
|
Thanks very much! I will take a closer look and also discuss it internally. |
Hi @samuel-marsh, I modified your PR to make |
Hi @saketkc makes sense and good idea to make optional. One change is that I believe ggrastr should be moved to the Suggests section instead of Imports in DESCRIPTION file as I believe anything in Imports section will be installed when installing Seurat which doesn't make it optional anymore. Thanks very much! |
Thanks for checking - I did remove it from imports, but did not add it to suggests, which I have fixed. |
Thanks a lot for your contribution, Sam! |
Hi Seurat Team,
Just a quick PR if you guys like it, that adds raster plotting to VlnPlots. Given individual data points can still be helpful but like other plots rendering that many points in vector form becomes inefficient in multiple ways.
I used ggrastr and added that to package imports page as well.
Thanks,
Sam