Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative to to.upper parameter Load10X_Spatial? #4576

Closed
samuel-marsh opened this issue Jun 4, 2021 · 3 comments
Closed

Alternative to to.upper parameter Load10X_Spatial? #4576

samuel-marsh opened this issue Jun 4, 2021 · 3 comments

Comments

@samuel-marsh
Copy link
Collaborator

HI Seurat Team,

Wondering whether there might be better alternative to the to.upper parameter in Load10X_Spatial? The goal as stated in manual makes sense: Can be useful when analyses require comparisons between human and mouse gene names for example.

However, in practice converting all the gene names to upper case may give user the false impression that genes with same name are homologous when that is not always the case (and name mismatches etc depending on reference annotation version).

It's not really feasible to call biomaRt (especially with modifications for different reference annotation versions) from within function like this but wondering if either a note in the manual about gene equivalency or temporarily disabling the parameter might be better? Obviously up to you but I think could be easy for many to miss the subtleties.

Best,
Sam

@jaisonj708 jaisonj708 self-assigned this Jun 4, 2021
@timoast
Copy link
Collaborator

timoast commented Aug 27, 2021

Hi @samuel-marsh, this is a very good point. The parameter is there mainly to facilitate quick comparisons between human and mouse, but for an accurate comparison across species the actual homologs need to be used. We'll update the documentation to make this clear

@timoast
Copy link
Collaborator

timoast commented Aug 27, 2021

This should now be updated on the develop branch

@timoast timoast closed this as completed Aug 27, 2021
@samuel-marsh
Copy link
Collaborator Author

Hi @timoast ya totally makes sense. Wanted to raise the issue so Seurat team could decide best course of activation (documentation vs. alterative funtion, etc). Looks good to me!

Best,
Sam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants