Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Test against arm64 on Travis #2783

Merged
merged 3 commits into from
Nov 23, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ jobs:
- stage: test
node_js: "12"
os: linux
arch: amd64
xzyfer marked this conversation as resolved.
Show resolved Hide resolved
before_script: npm run lint || exit 1;
xzyfer marked this conversation as resolved.
Show resolved Hide resolved
after_success: npm run-script coverage;
- stage: test
node_js: "12"
os: linux
arch: arm64
before_script: npm run lint || exit 1;
after_success: npm run-script coverage;
- stage: platform-test
Expand All @@ -15,12 +22,22 @@ jobs:
- stage: platform-test
node_js: "10"
os: linux
arch: amd64
- stage: platform-test
node_js: "10"
os: linux
arch: arm64
- stage: platform-test
node_js: "10"
os: osx
- stage: platform-test
node_js: "13"
os: linux
arch: amd64
- stage: platform-test
node_js: "13"
os: linux
arch: arm64
- stage: platform-test
node_js: "13"
os: osx
Expand Down
5 changes: 5 additions & 0 deletions lib/extensions.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ function getHumanArchitecture(arch) {
case 'ia32': return '32-bit';
case 'x86': return '32-bit';
case 'x64': return '64-bit';
case 'armv7l': return '32-bit, ARM';
case 'armv7hf': return '32-bit, ARM';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the arm64 prebuild binaries work on 32bit arm?

case 'armv8': return '64-bit, ARM';
case 'aarch64': return '64-bit, ARM';
case 'arm64': return '64-bit, ARM';
default: return false;
}
}
Expand Down