Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Test against arm64 on Travis #2783

Merged
merged 3 commits into from
Nov 23, 2019
Merged

Conversation

OskarPersson
Copy link

Follow-up to #2647, but instead of using a new CI service we use Travis new support for multiple CPU architectures

@xzyfer
Copy link
Contributor

xzyfer commented Nov 12, 2019

Can you please branch off of next-major rather than master

@OskarPersson OskarPersson changed the base branch from master to next-major November 12, 2019 09:03
@OskarPersson
Copy link
Author

Done

.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@OskarPersson
Copy link
Author

@xzyfer Not sure if you have the required permissions, but feel free to edit the files if you can :)

@@ -44,6 +44,11 @@ function getHumanArchitecture(arch) {
case 'ia32': return '32-bit';
case 'x86': return '32-bit';
case 'x64': return '64-bit';
case 'armv7l': return '32-bit, ARM';
case 'armv7hf': return '32-bit, ARM';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the arm64 prebuild binaries work on 32bit arm?

@xzyfer
Copy link
Contributor

xzyfer commented Nov 17, 2019

@OskarPersson
Copy link
Author

Yes, it is enabled. Are you pushing to https://github.com/OskarPersson/node-sass/tree/travis-arm ?

@xzyfer
Copy link
Contributor

xzyfer commented Nov 22, 2019

Committed the changes. Lets see how CI feels.

@xzyfer
Copy link
Contributor

xzyfer commented Nov 23, 2019

Thanks @OskarPersson. This is close enough to merge!

@xzyfer xzyfer merged commit 7ef1b8e into sass:next-major Nov 23, 2019
@OskarPersson OskarPersson deleted the travis-arm branch November 23, 2019 11:00
@thawkins
Copy link

Do you know when this will be publicaly available?, this is the last blocker to me having a full mongodb, node, react dev environment running in my samsung galaxy tab s6 android tablet under termux.

@autarchprinceps
Copy link

Having arm64 support isn't just a blocker for SBCs or phones or whatever. If you want to build arm64 docker images for use with stuff like AWS Graviton, not only would it be nice to no have to compile loads of stuff on npm install, which takes for ever, especially with buildx, I have so far seen a lot of failures there too.

@odidev
Copy link

odidev commented Feb 1, 2021

Thanks @OskarPersson. This is close enough to merge!

@xzyfer , May i know the reason for not adding these changes in further releases and in master? Is there anything I can help with?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants