-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Can you please branch off of next-major rather than master |
3cfa236
to
c35df30
Compare
Done |
c35df30
to
0a88ffe
Compare
@xzyfer Not sure if you have the required permissions, but feel free to edit the files if you can :) |
@@ -44,6 +44,11 @@ function getHumanArchitecture(arch) { | |||
case 'ia32': return '32-bit'; | |||
case 'x86': return '32-bit'; | |||
case 'x64': return '64-bit'; | |||
case 'armv7l': return '32-bit, ARM'; | |||
case 'armv7hf': return '32-bit, ARM'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the arm64 prebuild binaries work on 32bit arm?
@OskarPersson I don't appear to have access. Can you please double check you've given me access? |
Yes, it is enabled. Are you pushing to https://github.com/OskarPersson/node-sass/tree/travis-arm ? |
Committed the changes. Lets see how CI feels. |
Thanks @OskarPersson. This is close enough to merge! |
Do you know when this will be publicaly available?, this is the last blocker to me having a full mongodb, node, react dev environment running in my samsung galaxy tab s6 android tablet under termux. |
Having arm64 support isn't just a blocker for SBCs or phones or whatever. If you want to build arm64 docker images for use with stuff like AWS Graviton, not only would it be nice to no have to compile loads of stuff on npm install, which takes for ever, especially with buildx, I have so far seen a lot of failures there too. |
@xzyfer , May i know the reason for not adding these changes in further releases and in master? Is there anything I can help with? |
Follow-up to #2647, but instead of using a new CI service we use Travis new support for multiple CPU architectures