This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Update module version for Node 8 #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO(xzyfer): fix this post Node 8
nschonni
reviewed
May 16, 2017
| @@ -69,7 +69,8 @@ function getHumanNodeVersion(abi) { | |||
| case 47: return 'Node.js 5.x'; | |||
| case 48: return 'Node.js 6.x'; | |||
| case 51: return 'Node.js 7.x'; | |||
| case 54: return 'Node.js 8.x'; | |||
| case 55: return 'Node.js 8.x'; | |||
There was a problem hiding this comment.
Minor, but we chould just fall through here
There was a problem hiding this comment.
True. I did them as discrete commits so I didn't think about it. I want to update this handling so that it only shows as a helpful warning rather than erring out.
There was a problem hiding this comment.
can't we use a dictionary lookup instead of a switch?
function getHumanNodeVersion(abi) {
var humanNodeVersions={
11:'Node 0.10.x',
14:'Node 0.12.x',
42:'io.js 1.x',
43:'io.js 1.1.x',
44:'io.js 2.x',
45:'io.js 3.x',
46:'Node.js 4.x',
47:'Node.js 5.x',
48:'Node.js 6.x',
51:'Node.js 7.x',
55:'Node.js 8.x',
57:'Node.js 8.x'
}
var version = parseInt(abi || process.versions.modules, 10);
return humanNodeVersions[version]||false;
}There was a problem hiding this comment.
We could, but I prefer the switch.
|
Context: nodejs/citgm#389 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was 54 is now 55 will soon be 57.