Consistent node-sass failures on master

[mscdex]

• Node Version: master
• CitGM Version: whatever node CI is using
• Platform: any

It seems that node-sass explicitly checks process.versions.modules, but currently the master branch has a module version (53) that is not in their current modules version list, so a couple of the binding tests fail every time.

Is there some way we can ignore these particular errors for node-sass or perhaps mark it as flaky on master?

[gdams]

we can definitely mark node-sass as flaky on master

[gibfahn]

@xzyfer could node-sass either support master, or proceed even if a later module version is found?

[xzyfer]

@gibfahn we can fix these failing tests. They shouldn't fail the way they are. I'll look into to it asap.

[xzyfer]

My apologies for the delay. I've just release node-sass@v4.5.1 which should address the issue described. We'll work on a more permanent solution so you don't run into this again with Node 9.

[mscdex]

Reopening this as this seems to be happening again, my guess is because the module version (now 54) was bumped again due to the V8 5.7 upgrade.

ping @xzyfer

EDIT: PR incoming: sass/node-sass#1934

[xzyfer]

Will ship an update today. Will find time to make this more fault tolerant asap.

[xzyfer]

Published the fix in node-sass@v4.5.2

[mscdex]

Thanks!

[mscdex]

@xzyfer This is an issue again with node master, which currently has a modules version of '55'.

EDIT: Also note that master/v8.x will be upping its modules version higher sometime in the not-so-distant future too.

[xzyfer]

@mscdex patched in sass/node-sass#1969 and accounted for the bump to 57. Will ship in 4.5.3 with in the hour.

[MylesBorins]

Woot!!

…

On May 16, 2017 10:27 AM, "Michael Mifsud" ***@***.***> wrote: @mscdex <https://github.com/mscdex> patched in sass/node-sass#1969 <sass/node-sass#1969> and accounted for the bump to 57. Will ship in 4.5.3 with in the hour. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#389 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV8NPx7vVrMmsgVcYwMIVokJe_-uJks5r6bI3gaJpZM4MazYr> .

[xzyfer]

Published node-sass@4.5.3 with support for module version 55 and 57.

[tech4him1]

@xzyfer Will this be fixed for future versions, or will it still need to be upgraded every new Node version?

[xzyfer]

@tech4him1 this will be fixed for reals, but I'd be lying if put a date on it. We're working on a better solution.

[tech4him1]

@xzyfer Do you have an issue on node-sass that I can watch, or just here?