Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on "url" token (e.g. input[type=url]) in 3.4.x #2456

Closed
ochafik opened this issue Aug 4, 2017 · 4 comments
Closed

Regression on "url" token (e.g. input[type=url]) in 3.4.x #2456

ochafik opened this issue Aug 4, 2017 · 4 comments

Comments

@ochafik
Copy link

ochafik commented Aug 4, 2017

This works in 3.3.2:

input[type=url] {}

But fails in 3.4.5 with:

Error: Invalid CSS after "i": expected 1 selector or at-rule, was "input[type=url] {}"
        on line 1 of ../../test2.scss

Workaround: turning url to a string instead of an identifier:

input[type="url"] {}
@ochafik
Copy link
Author

ochafik commented Aug 4, 2017

Similarly, this source now fails to build with 3.4.5:

%url-status {}
url-status {}

While the following is fine:

.url-status {}
%foo-status {}

@ochafik ochafik changed the title Regression on "url" token (input[type=url]) in 3.4.x Regression on "url" token (e.g. input[type=url]) in 3.4.x Aug 4, 2017
ochafik added a commit to ochafik/libsass that referenced this issue Aug 4, 2017
ochafik added a commit to ochafik/libsass that referenced this issue Aug 4, 2017
@ochafik
Copy link
Author

ochafik commented Aug 4, 2017

Ah, I see this was already fixed in master by 82b8af6, cool!

Would you have any ETA for 3.4.6?

@asottile
Copy link
Member

asottile commented Sep 3, 2017

Seems an exact duplicate of #2429 -- a workaround (for now) is to use 3.4.4 or the betas until 3.4.6 is released

@ochafik
Copy link
Author

ochafik commented Sep 4, 2017

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants