Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: input[type=url] { ... } fails to parse #2429

Closed
asottile opened this issue Jun 29, 2017 · 2 comments
Closed

regression: input[type=url] { ... } fails to parse #2429

asottile opened this issue Jun 29, 2017 · 2 comments

Comments

@asottile
Copy link
Member

input.scss

input[type=url] {
  content: bar
}

Actual results

libsass 3.4.5 and libsass 3.5.0.beta.3-64-g5cb5

Error: Invalid CSS after "i": expected 1 selector or at-rule, was "input[type=url] {"
        on line 1 of test.scss
>> input[type=url] {
   ^

Expected result

libsass 3.4.4

input[type=url] {
  color: red; }

May also be related to: #2427

From bisect it appears to be this commit:

10398ed

10398ed299bffa7ccc32aace50dacbe1a51379a2 is the first bad commit
commit 10398ed299bffa7ccc32aace50dacbe1a51379a2
Author: Marcel Greter <marcel.greter@ocbnet.ch>
Date:   Sat May 20 19:01:04 2017 +0200

    Fix parser for urls looking like ruleset selectors (#2376)
@xzyfer
Copy link
Contributor

xzyfer commented Jun 30, 2017

Thanks @asottile, I'll take a look this weekend.

@asottile
Copy link
Member Author

asottile commented Jul 2, 2017

A workaround (I think?) is to use input[type="url"] { ... } instead.

@mgreter mgreter self-assigned this Jul 2, 2017
mgreter added a commit to mgreter/sass-spec that referenced this issue Jul 2, 2017
mgreter added a commit to mgreter/libsass that referenced this issue Jul 2, 2017
mgreter added a commit to mgreter/libsass that referenced this issue Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants