Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge origin/main into feature.color-4 #2339

Merged
merged 38 commits into from
Sep 12, 2024
Merged

Merge origin/main into feature.color-4 #2339

merged 38 commits into from
Sep 12, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 11, 2024

See sass/sass#3929
See sass/sass-spec#2012

[skip sass-embedded]

ntkme and others added 30 commits August 12, 2024 22:48
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
Thanks to Christophe Coevoet for pointing this out.
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.35.1 to 1.37.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.35.1...v1.37.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
Bumps [dartdoc](https://github.com/dart-lang/dartdoc) from 8.0.7 to 8.0.8.
- [Release notes](https://github.com/dart-lang/dartdoc/releases)
- [Changelog](https://github.com/dart-lang/dartdoc/blob/main/CHANGELOG.md)
- [Commits](https://github.com/dart-lang/dartdoc/commits)

---
updated-dependencies:
- dependency-name: dartdoc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is just a vertical slice designed to solidify the general
principles of the API design and ensure that everything works as
expected. It's not yet usable as a full-fledged parser.

Co-authored-by: Christophe Coevoet <stof@notk.org>
The Dart analyzer will soon be changed so that if the `default` clause
of a `switch` statement is determined to be unreachable by the
exhaustiveness checker, a new warning of type
`unreachable_switch_default` will be issued. This parallels the
behavior of the existing `unreachable_switch_case` warning, which is
issued whenever a `case` clause of a `switch` statement is determined
to be unreachable.

In the vast majority of cases, the most reasonable way to address the
warning is to remove the unreachable `default` clause. However, in a
few rare cases, the `default` clause must be kept, due to the fact
that flow analysis is not as sophisticated as exhaustiveness checking
(see dart-lang/language#2977 for details).

Two of these rare cases crop up in dart-sass. This change adds
`ignore` comments to avoid a spurious warning, and adds a comment
explaining why the `default` clause needs to be kept.
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.37.0 to 1.38.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.37.0...v1.38.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The Dart analyzer will soon be changed so that if the `default` clause
of a `switch` statement is determined to be unreachable by the
exhaustiveness checker, a new warning of type
`unreachable_switch_default` will be issued. This parallels the
behavior of the existing `unreachable_switch_case` warning, which is
issued whenever a `case` clause of a `switch` statement is determined
to be unreachable. For details see
dart-lang/sdk#54575.

This PR deletes an unreachable `default` clause from `dart-sass` now,
to avoid a spurious warning when the analyzer change lands.
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.38.0 to 1.39.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.38.0...v1.39.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add more statement parsing for `sass-parser`
jathak and others added 5 commits September 5, 2024 16:23
Add support for a couple more Sass statements
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.39.0 to 1.40.1.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.39.0...v1.40.1)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@nex3 nex3 force-pushed the merge-main branch 4 times, most recently from a5b8b30 to 519ce69 Compare September 11, 2024 23:33
This makes it harder to accidentally test against the wrong version,
and ensures CI doesn't break when the repo's Sass version number is
unreleased.
@nex3 nex3 merged commit 4db68a1 into feature.color-4 Sep 12, 2024
33 checks passed
@nex3 nex3 deleted the merge-main branch September 12, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants