Fix failing double check test for sass-parser #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
reviewed
Sep 3, 2024
tool/grind/double_check.dart
Outdated
| var pubspecFile = File("$dir/pubspec.yaml"); | ||
| if (pubspecFile.existsSync()) { | ||
| var pubspec = Pubspec.parse(pubspecFile.readAsStringSync(), | ||
| sourceUrl: p.toUri("$dir/pubspec.yaml")); |
There was a problem hiding this comment.
Suggested change
| sourceUrl: p.toUri("$dir/pubspec.yaml")); | |
| sourceUrl: pubspecFile.uri); |
This also allows removal of import 'package:path/path.dart'
nex3
approved these changes
Sep 3, 2024
tool/grind/double_check.dart
Outdated
| if (pubspec.version == package.latestPubspec.version) { | ||
| fail("${pubspec.name} ${pubspec.version} has already been released!"); | ||
| var pubspecFile = File("$dir/pubspec.yaml"); | ||
| if (pubspecFile.existsSync()) { |
There was a problem hiding this comment.
Nit: avoid excess indentation via
Suggested change
| if (pubspecFile.existsSync()) { | |
| if (!pubspecFile.existsSync()) continue; |
ntkme
reviewed
Sep 3, 2024
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: sass | |||
| version: 1.78.0 | |||
| version: 1.78.1 | |||
There was a problem hiding this comment.
Since nothing has actually been released, we could remove the git tag, and then retag the same release.
jathak
force-pushed
the
fix-double-check
branch
from
c4a58de
to
18439e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.