Skip to content

Commit

Permalink
Delete isDelegateCreationAllowed from the jitEEinterface.
Browse files Browse the repository at this point in the history
It became unused after dotnet#10626 (delete GetMethod2).
  • Loading branch information
Sergey Andreenko committed Jun 1, 2017
1 parent 148d418 commit 4ac0b4f
Show file tree
Hide file tree
Showing 12 changed files with 0 additions and 81 deletions.
3 changes: 0 additions & 3 deletions src/ToolBox/superpmi/superpmi-shared/icorjitinfoimpl.h
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,6 @@ BOOL isCompatibleDelegate(CORINFO_CLASS_HANDLE objCls, /* type of the
BOOL* pfIsOpenDelegate /* is the delegate open */
);

// Determines whether the delegate creation obeys security transparency rules
BOOL isDelegateCreationAllowed(CORINFO_CLASS_HANDLE delegateHnd, CORINFO_METHOD_HANDLE calleeHnd);

// Indicates if the method is an instance of the generic
// method that passes (or has passed) verification
CorInfoInstantiationVerification isInstantiationOfVerifiedGeneric(CORINFO_METHOD_HANDLE method /* IN */
Expand Down
9 changes: 0 additions & 9 deletions src/ToolBox/superpmi/superpmi-shim-collector/icorjitinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -303,15 +303,6 @@ BOOL interceptor_ICJI::isCompatibleDelegate(
return temp;
}

// Determines whether the delegate creation obeys security transparency rules
BOOL interceptor_ICJI::isDelegateCreationAllowed(CORINFO_CLASS_HANDLE delegateHnd, CORINFO_METHOD_HANDLE calleeHnd)
{
mc->cr->AddCall("isDelegateCreationAllowed");
BOOL temp = original_ICorJitInfo->isDelegateCreationAllowed(delegateHnd, calleeHnd);
mc->recIsDelegateCreationAllowed(delegateHnd, calleeHnd, temp);
return temp;
}

// Indicates if the method is an instance of the generic
// method that passes (or has passed) verification
CorInfoInstantiationVerification interceptor_ICJI::isInstantiationOfVerifiedGeneric(CORINFO_METHOD_HANDLE method /* IN
Expand Down
7 changes: 0 additions & 7 deletions src/ToolBox/superpmi/superpmi-shim-counter/icorjitinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -217,13 +217,6 @@ BOOL interceptor_ICJI::isCompatibleDelegate(
return original_ICorJitInfo->isCompatibleDelegate(objCls, methodParentCls, method, delegateCls, pfIsOpenDelegate);
}

// Determines whether the delegate creation obeys security transparency rules
BOOL interceptor_ICJI::isDelegateCreationAllowed(CORINFO_CLASS_HANDLE delegateHnd, CORINFO_METHOD_HANDLE calleeHnd)
{
mcs->AddCall("isDelegateCreationAllowed");
return original_ICorJitInfo->isDelegateCreationAllowed(delegateHnd, calleeHnd);
}

// Indicates if the method is an instance of the generic
// method that passes (or has passed) verification
CorInfoInstantiationVerification interceptor_ICJI::isInstantiationOfVerifiedGeneric(CORINFO_METHOD_HANDLE method /* IN
Expand Down
6 changes: 0 additions & 6 deletions src/ToolBox/superpmi/superpmi-shim-simple/icorjitinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -198,12 +198,6 @@ BOOL interceptor_ICJI::isCompatibleDelegate(
return original_ICorJitInfo->isCompatibleDelegate(objCls, methodParentCls, method, delegateCls, pfIsOpenDelegate);
}

// Determines whether the delegate creation obeys security transparency rules
BOOL interceptor_ICJI::isDelegateCreationAllowed(CORINFO_CLASS_HANDLE delegateHnd, CORINFO_METHOD_HANDLE calleeHnd)
{
return original_ICorJitInfo->isDelegateCreationAllowed(delegateHnd, calleeHnd);
}

// Indicates if the method is an instance of the generic
// method that passes (or has passed) verification
CorInfoInstantiationVerification interceptor_ICJI::isInstantiationOfVerifiedGeneric(CORINFO_METHOD_HANDLE method /* IN
Expand Down
7 changes: 0 additions & 7 deletions src/ToolBox/superpmi/superpmi/icorjitinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,6 @@ BOOL MyICJI::isCompatibleDelegate(CORINFO_CLASS_HANDLE objCls, /* type
return jitInstance->mc->repIsCompatibleDelegate(objCls, methodParentCls, method, delegateCls, pfIsOpenDelegate);
}

// Determines whether the delegate creation obeys security transparency rules
BOOL MyICJI::isDelegateCreationAllowed(CORINFO_CLASS_HANDLE delegateHnd, CORINFO_METHOD_HANDLE calleeHnd)
{
jitInstance->mc->cr->AddCall("isDelegateCreationAllowed");
return jitInstance->mc->repIsDelegateCreationAllowed(delegateHnd, calleeHnd);
}

// Indicates if the method is an instance of the generic
// method that passes (or has passed) verification
CorInfoInstantiationVerification MyICJI::isInstantiationOfVerifiedGeneric(CORINFO_METHOD_HANDLE method /* IN */
Expand Down
7 changes: 0 additions & 7 deletions src/inc/corinfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -2111,13 +2111,6 @@ class ICorStaticInfo
BOOL *pfIsOpenDelegate /* is the delegate open */
) = 0;

// Determines whether the delegate creation obeys security transparency rules
virtual BOOL isDelegateCreationAllowed (
CORINFO_CLASS_HANDLE delegateHnd,
CORINFO_METHOD_HANDLE calleeHnd
) = 0;


// Indicates if the method is an instance of the generic
// method that passes (or has passed) verification
virtual CorInfoInstantiationVerification isInstantiationOfVerifiedGeneric (
Expand Down
1 change: 0 additions & 1 deletion src/jit/ICorJitInfo_API_names.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ DEF_CLR_API(getUnmanagedCallConv)
DEF_CLR_API(pInvokeMarshalingRequired)
DEF_CLR_API(satisfiesMethodConstraints)
DEF_CLR_API(isCompatibleDelegate)
DEF_CLR_API(isDelegateCreationAllowed)
DEF_CLR_API(isInstantiationOfVerifiedGeneric)
DEF_CLR_API(initConstraintsForVerification)
DEF_CLR_API(canSkipMethodVerification)
Expand Down
11 changes: 0 additions & 11 deletions src/jit/ICorJitInfo_API_wrapper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -189,17 +189,6 @@ BOOL WrapICorJitInfo::isCompatibleDelegate(
return temp;
}

BOOL WrapICorJitInfo::isDelegateCreationAllowed(
CORINFO_CLASS_HANDLE delegateHnd,
CORINFO_METHOD_HANDLE calleeHnd)
{
API_ENTER(isDelegateCreationAllowed);
BOOL temp = wrapHnd->isDelegateCreationAllowed(delegateHnd, calleeHnd);
API_LEAVE(isDelegateCreationAllowed);
return temp;
}


CorInfoInstantiationVerification WrapICorJitInfo::isInstantiationOfVerifiedGeneric(
CORINFO_METHOD_HANDLE method /* IN */)
{
Expand Down
15 changes: 0 additions & 15 deletions src/vm/jitinterface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9579,21 +9579,6 @@ BOOL CEEInfo::isCompatibleDelegate(
return result;
}

// Determines whether the delegate creation obeys security transparency rules
BOOL CEEInfo::isDelegateCreationAllowed (
CORINFO_CLASS_HANDLE delegateHnd,
CORINFO_METHOD_HANDLE calleeHnd)
{
CONTRACTL {
SO_TOLERANT;
THROWS;
GC_TRIGGERS;
MODE_PREEMPTIVE;
} CONTRACTL_END;

return TRUE;
}

/*********************************************************************/
// return the unmanaged target *if method has already been prelinked.*
void* CEEInfo::getPInvokeUnmanagedTarget(CORINFO_METHOD_HANDLE method,
Expand Down
5 changes: 0 additions & 5 deletions src/vm/jitinterface.h
Original file line number Diff line number Diff line change
Expand Up @@ -777,11 +777,6 @@ class CEEInfo : public ICorJitInfo
CORINFO_CLASS_HANDLE delegateCls,
BOOL* pfIsOpenDelegate);

// Determines whether the delegate creation obeys security transparency rules
BOOL isDelegateCreationAllowed (
CORINFO_CLASS_HANDLE delegateHnd,
CORINFO_METHOD_HANDLE calleeHnd);

// ICorFieldInfo stuff
const char* getFieldName (CORINFO_FIELD_HANDLE field,
const char** scopeName);
Expand Down
7 changes: 0 additions & 7 deletions src/zap/zapinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3778,13 +3778,6 @@ BOOL ZapInfo::isCompatibleDelegate(
return m_pEEJitInfo->isCompatibleDelegate(objCls, methodParentCls, method, delegateCls, pfIsOpenDelegate);
}

BOOL ZapInfo::isDelegateCreationAllowed (
CORINFO_CLASS_HANDLE delegateHnd,
CORINFO_METHOD_HANDLE calleeHnd)
{
return m_pEEJitInfo->isDelegateCreationAllowed(delegateHnd, calleeHnd);
}

//
// ICorErrorInfo
//
Expand Down
3 changes: 0 additions & 3 deletions src/zap/zapinfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -688,9 +688,6 @@ class ZapInfo
CORINFO_CLASS_HANDLE delegateCls,
BOOL* pfIsOpenDelegate);

BOOL isDelegateCreationAllowed(CORINFO_CLASS_HANDLE delegateHnd,
CORINFO_METHOD_HANDLE calleeHnd);

void getGSCookie(GSCookie * pCookieVal,
GSCookie** ppCookieVal);
// ICorErrorInfo
Expand Down

0 comments on commit 4ac0b4f

Please sign in to comment.