This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
delete GetMethod2 #10626
Merged
delete GetMethod2 #10626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @BruceForstall @pgavlin @dotnet/jit-contrib. |
jkotas
reviewed
Mar 31, 2017
src/jit/importer.cpp
Outdated
| @@ -12814,10 +12814,17 @@ void Compiler::impImportBlockCode(BasicBlock* block) | |||
|
|
|||
| #ifdef FEATURE_CORECLR | |||
| // In coreclr the delegate transparency rule needs to be enforced even if verification is disabled | |||
There was a problem hiding this comment.
You can delete this whole block instead and the impInsertCalloutForDelegate method. We are not doing any delegate transparency check in CoreCLR anymore. It is left-over from Silverlight in a browser.
There was a problem hiding this comment.
I am not familiar with that enough, but it sounds great. Thanks.
There was a problem hiding this comment.
Do we want to delete isDelegateCreationAllowed from JitEE interface?
There was a problem hiding this comment.
Do we want to delete isDelegateCreationAllowed from JitEE interface?
It would be nice. It should be fine to do it together with the next JITEE interface change.
sandreenko
force-pushed
the
delete-GetMethod2
branch
from
3601a4a
to
962c464
Compare
jkotas
approved these changes
Apr 1, 2017
sandreenko
pushed a commit
to sandreenko/coreclr
that referenced
this pull request
Jun 3, 2017
It became unused after dotnet#10626 (delete GetMethod2).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description is in #10620 .
I need to delete this methods because I want to add another class inside the union in typeInfo for resolver token. It is necessary for dotnet/corert#2102. All methods that work with typeInfo should check type.